[dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x

Christian Ehrhardt christian.ehrhardt at canonical.com
Tue Jun 1 10:05:32 CEST 2021


Hi,
this was targeted for dpdk stable releases.

commit b6579e3db794be36637a66e009199a1e7451e995
Author: Huisong Li <lihuisong at huawei.com>
Date:   Tue Mar 23 21:45:51 2021 +0800

    net/hns3: fix reporting undefined speed

It introduced

[  403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:
In function 'hns3_dev_link_update':
[  403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:2618:26:
error: 'ETH_SPEED_NUM_UNKNOWN' undeclared (first use in this function)
[  403s]     new_link.link_speed = ETH_SPEED_NUM_UNKNOWN;
[  403s]                           ^

But that requires this change from 20.11:

commit 810b17d116f03783843d23ac900a3794675f6616
Author: Thomas Monjalon <thomas at monjalon.net>
Date:   Tue Aug 11 11:52:20 2020 +0300

    ethdev: allow unknown link speed

I'm unsure if introducing ETH_SPEED_NUM_UNKNOWN in 19.11 might break
other bits not aware of it so for now I have removed that formerly
queued patch from 19.11.9.

If you want it applied to 19.11.9 or later please have a look and
consider providing a backport for it - or alternatively if you think it
is not important for 19.11.x let me know about that.

-- 
Christian Ehrhardt
Staff Engineer, Ubuntu Server
Canonical Ltd


More information about the stable mailing list