[dpdk-stable] [PATCH] net/mlx5: remove unwanted barrier
Honnappa Nagarahalli
honnappa.nagarahalli at arm.com
Sun Jun 6 18:49:48 CEST 2021
The IO barrier is not required as cqe->op_own is read once. The
checks done on the local variable and the memory is not read again.
Fixes: 88c0733535d6 ("net/mlx5: extend Rx completion with error handling")
Cc: matan at mellanox.com
Cc: stable at dpdk.org
Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
---
drivers/common/mlx5/mlx5_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/mlx5/mlx5_common.h b/drivers/common/mlx5/mlx5_common.h
index 5028a05b49..a4c29f51f1 100644
--- a/drivers/common/mlx5/mlx5_common.h
+++ b/drivers/common/mlx5/mlx5_common.h
@@ -195,7 +195,7 @@ check_cqe(volatile struct mlx5_cqe *cqe, const uint16_t cqes_n,
if (unlikely((op_owner != (!!(idx))) || (op_code == MLX5_CQE_INVALID)))
return MLX5_CQE_STATUS_HW_OWN;
- rte_io_rmb();
+
if (unlikely(op_code == MLX5_CQE_RESP_ERR ||
op_code == MLX5_CQE_REQ_ERR))
return MLX5_CQE_STATUS_ERR;
--
2.17.1
More information about the stable
mailing list