[dpdk-stable] patch 'raw/skeleton: add missing check after setting attribute' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Thu Jun 10 14:05:52 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/6285f76a753f831f2e1853766def7ca4f54bb4eb

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 6285f76a753f831f2e1853766def7ca4f54bb4eb Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Thu, 22 Apr 2021 14:21:46 +0800
Subject: [PATCH] raw/skeleton: add missing check after setting attribute

[ upstream commit b97012825dfad7d30bbd1fa99ec6115eba6135ce ]

This patch adds return value check for setting an attribute.

Fixes: 88a81bcecb7b ("raw/skeleton: remove compile-time constant for device id")

Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/raw/skeleton/skeleton_rawdev_test.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/raw/skeleton/skeleton_rawdev_test.c b/drivers/raw/skeleton/skeleton_rawdev_test.c
index 1190e28bb7..fa7f4fab5e 100644
--- a/drivers/raw/skeleton/skeleton_rawdev_test.c
+++ b/drivers/raw/skeleton/skeleton_rawdev_test.c
@@ -291,6 +291,7 @@ test_rawdev_attr_set_get(void)
 	dummy_value = &set_value;
 	*dummy_value = 200;
 	ret = rte_rawdev_set_attr(test_dev_id, "Test2", (uintptr_t)dummy_value);
+	RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test2)");
 
 	/* Check if attributes have been set */
 	ret = rte_rawdev_get_attr(test_dev_id, "Test1", &ret_value);
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-10 14:04:58.287275179 +0200
+++ 0004-raw-skeleton-add-missing-check-after-setting-attribu.patch	2021-06-10 14:04:57.994024108 +0200
@@ -1 +1 @@
-From b97012825dfad7d30bbd1fa99ec6115eba6135ce Mon Sep 17 00:00:00 2001
+From 6285f76a753f831f2e1853766def7ca4f54bb4eb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b97012825dfad7d30bbd1fa99ec6115eba6135ce ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -17 +18 @@
-index 1405df080d..484468eeb4 100644
+index 1190e28bb7..fa7f4fab5e 100644
@@ -20 +21 @@
-@@ -295,6 +295,7 @@ test_rawdev_attr_set_get(void)
+@@ -291,6 +291,7 @@ test_rawdev_attr_set_get(void)


More information about the stable mailing list