[dpdk-stable] patch 'net/hns3: fix ordering in secondary process initialization' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Thu Jun 10 14:06:08 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/69d191654f68e1c6510e7cdbc632d653874fd6d2

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 69d191654f68e1c6510e7cdbc632d653874fd6d2 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Mon, 10 May 2021 21:38:12 +0800
Subject: [PATCH] net/hns3: fix ordering in secondary process initialization

[ upstream commit ac8962e96599b713b3e87d22be602a2d9d951321 ]

The memory barrier is used to ensure that the response is returned
only after the Tx/Rx function is set, it should place after the Rx/Tx
function is set.

Fixes: 23d4b61fee5d ("net/hns3: support multiple process")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/net/hns3/hns3_mp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/hns3/hns3_mp.c b/drivers/net/hns3/hns3_mp.c
index 649f896de2..a03f2cf13c 100644
--- a/drivers/net/hns3/hns3_mp.c
+++ b/drivers/net/hns3/hns3_mp.c
@@ -88,8 +88,8 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
 	case HNS3_MP_REQ_START_RXTX:
 		PMD_INIT_LOG(INFO, "port %u starting datapath",
 			     dev->data->port_id);
-		rte_mb();
 		hns3_set_rxtx_function(dev);
+		rte_mb();
 		mp_init_msg(dev, &mp_res, param->type);
 		res->result = 0;
 		ret = rte_mp_reply(&mp_res, peer);
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-10 14:04:59.014850489 +0200
+++ 0020-net-hns3-fix-ordering-in-secondary-process-initializ.patch	2021-06-10 14:04:58.042024466 +0200
@@ -1 +1 @@
-From ac8962e96599b713b3e87d22be602a2d9d951321 Mon Sep 17 00:00:00 2001
+From 69d191654f68e1c6510e7cdbc632d653874fd6d2 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ac8962e96599b713b3e87d22be602a2d9d951321 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index cab784f42a..a8485f5cfd 100644
+index 649f896de2..a03f2cf13c 100644
@@ -23 +24 @@
-@@ -86,8 +86,8 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)
+@@ -88,8 +88,8 @@ mp_secondary_handle(const struct rte_mp_msg *mp_msg, const void *peer)


More information about the stable mailing list