[dpdk-stable] patch 'app/crypto-perf: check memory allocation' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Thu Jun 10 14:06:19 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/02d8cd1aef6dd237588b159671c96112776144c9

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 02d8cd1aef6dd237588b159671c96112776144c9 Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Thu, 6 May 2021 14:13:59 +0800
Subject: [PATCH] app/crypto-perf: check memory allocation

[ upstream commit 37c0359bc550e0cf3938382553c7dbb4fb21567d ]

Return value of a function 'rte_zmalloc' is dereferenced without
checking, and it may call segmentation fault.

This patch fixed it.

Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")

Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
---
 app/test-crypto-perf/cperf_options_parsing.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/test-crypto-perf/cperf_options_parsing.c b/app/test-crypto-perf/cperf_options_parsing.c
index 22bf9cd4d6..e16e8eca9c 100644
--- a/app/test-crypto-perf/cperf_options_parsing.c
+++ b/app/test-crypto-perf/cperf_options_parsing.c
@@ -495,6 +495,12 @@ parse_test_name(struct cperf_options *opts,
 {
 	char *test_name = (char *) rte_zmalloc(NULL,
 		sizeof(char) * (strlen(arg) + 3), 0);
+	if (test_name == NULL) {
+		RTE_LOG(ERR, USER1, "Failed to rte zmalloc with size: %zu\n",
+			strlen(arg) + 3);
+		return -1;
+	}
+
 	snprintf(test_name, strlen(arg) + 3, "[%s]", arg);
 	opts->test_name = test_name;
 
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-10 14:04:59.551738875 +0200
+++ 0031-app-crypto-perf-check-memory-allocation.patch	2021-06-10 14:04:58.062024614 +0200
@@ -1 +1 @@
-From 37c0359bc550e0cf3938382553c7dbb4fb21567d Mon Sep 17 00:00:00 2001
+From 02d8cd1aef6dd237588b159671c96112776144c9 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 37c0359bc550e0cf3938382553c7dbb4fb21567d ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 40b6dfb648..e84f56cfaa 100644
+index 22bf9cd4d6..e16e8eca9c 100644
@@ -24 +25 @@
-@@ -506,6 +506,12 @@ parse_test_name(struct cperf_options *opts,
+@@ -495,6 +495,12 @@ parse_test_name(struct cperf_options *opts,


More information about the stable mailing list