[dpdk-stable] patch 'net/mlx5: fix leak when configured repeatedly' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Thu Jun 10 14:06:34 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/5c78bf88aafdd8eca4364bf0c02c6d5a8065c98b

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 5c78bf88aafdd8eca4364bf0c02c6d5a8065c98b Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Thu, 13 May 2021 11:39:54 +0800
Subject: [PATCH] net/mlx5: fix leak when configured repeatedly

[ upstream commit 6dad8b3a381911c6f7fe0362517bee9bfc24def3 ]

Currently, configuring a mlx device, it will allocate its
own process private in mlx5_proc_priv_init() and only frees
it when closing the device. This will lead to a memory leak,
when a device is configured repeatedly.

For example:
for(...)
do
    rte_eth_dev_configure
    rte_eth_rx_queue_setup
    rte_eth_tx_queue_setup
    rte_eth_dev_start
    rte_eth_dev_stop
done

Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 drivers/net/mlx5/mlx5.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index e0ba600868..3208b2eda7 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -1255,6 +1255,7 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)
 	struct mlx5_proc_priv *ppriv;
 	size_t ppriv_size;
 
+	mlx5_proc_priv_uninit(dev);
 	/*
 	 * UAR register table follows the process private structure. BlueFlame
 	 * registers for Tx queues are stored in the table.
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-10 14:05:00.225967966 +0200
+++ 0046-net-mlx5-fix-leak-when-configured-repeatedly.patch	2021-06-10 14:04:58.090024821 +0200
@@ -1 +1 @@
-From 6dad8b3a381911c6f7fe0362517bee9bfc24def3 Mon Sep 17 00:00:00 2001
+From 5c78bf88aafdd8eca4364bf0c02c6d5a8065c98b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6dad8b3a381911c6f7fe0362517bee9bfc24def3 ]
+
@@ -22 +23,0 @@
-Cc: stable at dpdk.org
@@ -31 +32 @@
-index 35f91e965e..cf1815cb74 100644
+index e0ba600868..3208b2eda7 100644
@@ -34 +35 @@
-@@ -1455,6 +1455,7 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)
+@@ -1255,6 +1255,7 @@ mlx5_proc_priv_init(struct rte_eth_dev *dev)


More information about the stable mailing list