[dpdk-stable] [PATCH v5] eal: arm: fix out of tree build

David Marchand david.marchand at redhat.com
Fri Jun 11 11:54:25 CEST 2021


Hello Bruce,

On Wed, Jun 9, 2021 at 12:18 PM Michael Pfeiffer
<michael.pfeiffer at tu-ilmenau.de> wrote:
>
> Including various headers may fail for ARM builds with 'Platform must
> be built with RTE_FORCE_INTRINSICS' if rte_config.h is not included
> before. Move the error message after the includes to ensure rte_config.h
> is always included.
>
> Fixes: de966ccdcd7f ("eal/arm: add byte order operations for ARM")
> Fixes: 17d5fa0fa90d ("eal/arm: add atomic operations for ARMv7")
> Fixes: d708f01b7102 ("eal/arm: add atomic operations for ARMv8")
> Fixes: 2173f3333b61 ("mcslock: add MCS queued lock implementation")
> Fixes: 7860c3965483 ("eal/arm: add spinlock operations for ARM")
> Fixes: ca49b92079df ("ticketlock: enable generic ticketlock on all arch")
> Cc: stable at dpdk.org
> Cc: kosar at rehivetech.com
> Cc: phil.yang at arm.com
> Cc: joyce.kong at arm.com
>
> Signed-off-by: Michael Pfeiffer <michael.pfeiffer at tu-ilmenau.de>

The header check currently compiles all headers with an implicit
"-include rte_config.h".
I suppose this is because it comes from the project level meson configuration.

Would there be a way to detect the issue fixed by this patch?


-- 
David Marchand



More information about the stable mailing list