[dpdk-stable] patch 'test/mempool: fix object initializer' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:01:40 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/8ad8d124a5584d7817f5654eabdbd61ae8b2994d

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 8ad8d124a5584d7817f5654eabdbd61ae8b2994d Mon Sep 17 00:00:00 2001
From: Olivier Matz <olivier.matz at 6wind.com>
Date: Tue, 27 Apr 2021 15:56:45 +0200
Subject: [PATCH] test/mempool: fix object initializer
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit e1064f80b61157250250353718ff196d2f050041 ]

The function rte_pktmbuf_init() expects that the mempool private area is
large enough and was previously initialized by rte_pktmbuf_pool_init(),
which is not the case.

This causes the function rte_pktmbuf_priv_size() to return an
unpredictable value, and this value is used as a size in a memset.

Replace the mempool object initializer by my_obj_init(), which does not
have this constraint, and fits the needs for this test.

Fixes: 923ceaeac140 ("test/mempool: add unit test cases")

Reported-by: Wenwu Ma <wenwux.ma at intel.com>
Signed-off-by: Olivier Matz <olivier.matz at 6wind.com>
---
 app/test/test_mempool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 084842fdaa..3adadd6731 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -552,7 +552,7 @@ test_mempool(void)
 		GOTO_ERR(ret, err);
 
 	/* test to initialize mempool objects and memory */
-	nb_objs = rte_mempool_obj_iter(mp_stack_mempool_iter, rte_pktmbuf_init,
+	nb_objs = rte_mempool_obj_iter(mp_stack_mempool_iter, my_obj_init,
 			NULL);
 	if (nb_objs == 0)
 		GOTO_ERR(ret, err);
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:56.852962600 +0800
+++ 0006-test-mempool-fix-object-initializer.patch	2021-06-12 06:53:56.000000000 +0800
@@ -1 +1 @@
-From e1064f80b61157250250353718ff196d2f050041 Mon Sep 17 00:00:00 2001
+From 8ad8d124a5584d7817f5654eabdbd61ae8b2994d Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit e1064f80b61157250250353718ff196d2f050041 ]
@@ -17 +19,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list