[dpdk-stable] patch 'net/bonding: fix leak on remove' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:01:53 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/448c880b6e95911ded654811d755db122b4f1c96

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 448c880b6e95911ded654811d755db122b4f1c96 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 22 Apr 2021 10:05:02 +0800
Subject: [PATCH] net/bonding: fix leak on remove
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb ]

If the bond device was created by vdev mode, the kvlist was not free
when the bond device removed.

Fixes: 8d30fe7fa737 ("bonding: support port hotplug")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 057b1ada54..9bcef952ea 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3459,6 +3459,8 @@ bond_remove(struct rte_vdev_device *dev)
 		ret = bond_ethdev_stop(eth_dev);
 		bond_ethdev_close(eth_dev);
 	}
+	if (internals->kvlist != NULL)
+		rte_kvargs_free(internals->kvlist);
 	rte_eth_dev_release_port(eth_dev);
 
 	return ret;
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:57.191938900 +0800
+++ 0019-net-bonding-fix-leak-on-remove.patch	2021-06-12 06:53:56.100000000 +0800
@@ -1 +1 @@
-From 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb Mon Sep 17 00:00:00 2001
+From 448c880b6e95911ded654811d755db122b4f1c96 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 2e9cea5b8e..25b1f771a1 100644
+index 057b1ada54..9bcef952ea 100644
@@ -23 +25 @@
-@@ -3467,6 +3467,8 @@ bond_remove(struct rte_vdev_device *dev)
+@@ -3459,6 +3459,8 @@ bond_remove(struct rte_vdev_device *dev)


More information about the stable mailing list