[dpdk-stable] patch 'net/hns3: fix handling link update' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:02:02 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/551f3198b8fdf7dda1116b6f7b0e3c77d356f204

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 551f3198b8fdf7dda1116b6f7b0e3c77d356f204 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Tue, 27 Apr 2021 20:17:39 +0800
Subject: [PATCH] net/hns3: fix handling link update
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit fae9b062b01397339c02c88ebee11dd5f7af3e3c ]

The link fails code should be parsed using the structure
hns3_mbx_vf_to_pf_cmd, else it will parse fail.

Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/net/hns3/hns3_mbx.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index 2ca0dffcf9..6f0a216d11 100644
--- a/drivers/net/hns3/hns3_mbx.c
+++ b/drivers/net/hns3/hns3_mbx.c
@@ -355,7 +355,7 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)
 
 static void
 hns3_handle_link_change_event(struct hns3_hw *hw,
-			      struct hns3_mbx_pf_to_vf_cmd *req)
+				struct hns3_mbx_vf_to_pf_cmd *req)
 {
 #define LINK_STATUS_OFFSET     1
 #define LINK_FAIL_CODE_OFFSET  2
@@ -524,7 +524,14 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
 			hns3_mbx_handler(hw);
 			break;
 		case HNS3_MBX_PUSH_LINK_STATUS:
-			hns3_handle_link_change_event(hw, req);
+			/*
+			 * This message is reported by the firmware and is
+			 * reported in 'struct hns3_mbx_vf_to_pf_cmd' format.
+			 * Therefore, we should cast the req variable to
+			 * 'struct hns3_mbx_vf_to_pf_cmd' and then process it.
+			 */
+			hns3_handle_link_change_event(hw,
+				(struct hns3_mbx_vf_to_pf_cmd *)req);
 			break;
 		case HNS3_MBX_PUSH_VLAN_INFO:
 			/*
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:57.420819700 +0800
+++ 0028-net-hns3-fix-handling-link-update.patch	2021-06-12 06:53:56.150000000 +0800
@@ -1 +1 @@
-From fae9b062b01397339c02c88ebee11dd5f7af3e3c Mon Sep 17 00:00:00 2001
+From 551f3198b8fdf7dda1116b6f7b0e3c77d356f204 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit fae9b062b01397339c02c88ebee11dd5f7af3e3c ]
@@ -10 +12,0 @@
-Cc: stable at dpdk.org
@@ -19 +21 @@
-index ba04ac9e90..31ab130aae 100644
+index 2ca0dffcf9..6f0a216d11 100644
@@ -22 +24 @@
-@@ -347,7 +347,7 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)
+@@ -355,7 +355,7 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)
@@ -25 +27 @@
- hns3pf_handle_link_change_event(struct hns3_hw *hw,
+ hns3_handle_link_change_event(struct hns3_hw *hw,
@@ -31,2 +33,2 @@
-@@ -513,7 +513,14 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
- 			hns3_handle_asserting_reset(hw, req);
+@@ -524,7 +524,14 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
+ 			hns3_mbx_handler(hw);
@@ -35 +37 @@
--			hns3pf_handle_link_change_event(hw, req);
+-			hns3_handle_link_change_event(hw, req);
@@ -42 +44 @@
-+			hns3pf_handle_link_change_event(hw,
++			hns3_handle_link_change_event(hw,


More information about the stable mailing list