[dpdk-stable] patch 'net/bnxt: fix mismatched type comparison in MAC restore' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:02:51 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/91d4a1731abb2cd8b1f6df56beea9cf9df51932e

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 91d4a1731abb2cd8b1f6df56beea9cf9df51932e Mon Sep 17 00:00:00 2001
From: Ajit Khaparde <ajit.khaparde at broadcom.com>
Date: Fri, 30 Apr 2021 13:14:10 -0700
Subject: [PATCH] net/bnxt: fix mismatched type comparison in MAC restore
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit c8e8154390b38f9242249eb1e023df1db976a285 ]

dev_info.max_mac_addrs is of type uint32_t. But the counter i is
of type uint16_t. This mismatch may cause the loop condition may
always be true. Change the loop counter variable to uint32_t.

Fixes: b02f1573cd07 ("net/bnxt: restore MAC filters during reset recovery")

Signed-off-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index e042466995..25f99fbc70 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -3972,7 +3972,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp)
 	struct rte_ether_addr *addr;
 	uint64_t pool_mask;
 	uint32_t pool = 0;
-	uint16_t i;
+	uint32_t i;
 	int rc;
 
 	if (BNXT_VF(bp) && !BNXT_VF_IS_TRUSTED(bp))
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:58.592420200 +0800
+++ 0077-net-bnxt-fix-mismatched-type-comparison-in-MAC-resto.patch	2021-06-12 06:53:56.360000000 +0800
@@ -1 +1 @@
-From c8e8154390b38f9242249eb1e023df1db976a285 Mon Sep 17 00:00:00 2001
+From 91d4a1731abb2cd8b1f6df56beea9cf9df51932e Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit c8e8154390b38f9242249eb1e023df1db976a285 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 9c3e0f9f36..115acda9b3 100644
+index e042466995..25f99fbc70 100644
@@ -23 +25 @@
-@@ -3989,7 +3989,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp)
+@@ -3972,7 +3972,7 @@ static int bnxt_restore_mac_filters(struct bnxt *bp)


More information about the stable mailing list