[dpdk-stable] patch 'net/ena: fix crash with unsupported device argument' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:03:28 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/967dcfb168c8e8d79df4e5855b27cd66b68cc0f2

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 967dcfb168c8e8d79df4e5855b27cd66b68cc0f2 Mon Sep 17 00:00:00 2001
From: Michal Krawczyk <mk at semihalf.com>
Date: Tue, 11 May 2021 08:45:47 +0200
Subject: [PATCH] net/ena: fix crash with unsupported device argument
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 9f220a959d4d7208491efea8ca8e0c4a96b98f0e ]

As the documentation of rte_kvargs_parse() states, the valid_keys
argument must be NULL terminated. Lack of this feature may cause
segmentation fault if the passed devarg will be different then the
supported value.

Fixes: 8a7a73f26cc9 ("net/ena: support large LLQ headers")

Signed-off-by: Michal Krawczyk <mk at semihalf.com>
Reviewed-by: Igor Chauskin <igorch at amazon.com>
Reviewed-by: Shay Agroskin <shayagr at amazon.com>
Acked-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/ena/ena_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index e7547af144..46ef021072 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -2876,6 +2876,7 @@ static int ena_parse_devargs(struct ena_adapter *adapter,
 {
 	static const char * const allowed_args[] = {
 		ENA_DEVARG_LARGE_LLQ_HDR,
+		NULL,
 	};
 	struct rte_kvargs *kvlist;
 	int rc;
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:59.523900000 +0800
+++ 0114-net-ena-fix-crash-with-unsupported-device-argument.patch	2021-06-12 06:53:56.500000000 +0800
@@ -1 +1 @@
-From 9f220a959d4d7208491efea8ca8e0c4a96b98f0e Mon Sep 17 00:00:00 2001
+From 967dcfb168c8e8d79df4e5855b27cd66b68cc0f2 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 9f220a959d4d7208491efea8ca8e0c4a96b98f0e ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index 53647cc56e..9721a70cf8 100644
+index e7547af144..46ef021072 100644


More information about the stable mailing list