[dpdk-stable] patch 'app/testpmd: fix tunnel offload flows cleanup' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:03:43 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/18151dfdcb4ed88b44d7c21244442dad671b8d36

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 18151dfdcb4ed88b44d7c21244442dad671b8d36 Mon Sep 17 00:00:00 2001
From: Gregory Etelson <getelson at nvidia.com>
Date: Tue, 11 May 2021 11:03:31 +0300
Subject: [PATCH] app/testpmd: fix tunnel offload flows cleanup
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 99fc79b37af5652f30ab3c9725fd6a98494d14dc ]

Tunnel offload model requires application to obtain PMD related flow
items or actions to construct a flow rule. These elements acquire
internal PMD flow resources that must be explicitly released.

The patch destroys tunnel offload PMD resources after flow creation
failure.

Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")

Signed-off-by: Gregory Etelson <getelson at nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 app/test-pmd/config.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 25c2340d74..937a90f3cd 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2115,6 +2115,9 @@ port_flow_create(portid_t port_id,
 	memset(&error, 0x22, sizeof(error));
 	flow = rte_flow_create(port_id, attr, pattern, actions, &error);
 	if (!flow) {
+		if (tunnel_ops->enabled)
+			port_flow_tunnel_offload_cmd_release(port_id,
+							     tunnel_ops, pft);
 		free(pf);
 		return port_flow_complain(&error);
 	}
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:53:59.884103700 +0800
+++ 0129-app-testpmd-fix-tunnel-offload-flows-cleanup.patch	2021-06-12 06:53:56.540000000 +0800
@@ -1 +1 @@
-From 99fc79b37af5652f30ab3c9725fd6a98494d14dc Mon Sep 17 00:00:00 2001
+From 18151dfdcb4ed88b44d7c21244442dad671b8d36 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 99fc79b37af5652f30ab3c9725fd6a98494d14dc ]
@@ -14 +16,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index 01a541cdd6..43c79b5021 100644
+index 25c2340d74..937a90f3cd 100644
@@ -26 +28 @@
-@@ -1940,6 +1940,9 @@ port_flow_create(portid_t port_id,
+@@ -2115,6 +2115,9 @@ port_flow_create(portid_t port_id,


More information about the stable mailing list