[dpdk-stable] patch 'test/crypto: fix return value of a skipped test' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:03:58 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/010e63f5eefffe31c51ed79305a43bc856625824

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 010e63f5eefffe31c51ed79305a43bc856625824 Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Wed, 12 May 2021 11:36:54 +0000
Subject: [PATCH] test/crypto: fix return value of a skipped test
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 085f128aac8119a3cd1b903398dc92771da4ad38 ]

The blockcipher testcase return value TEST_SUCCESS was incorrect for
one conditional check, it should have been TEST_SKIPPED similar to the
other condition checks in this function when the testcase is skipped.

Fixes: 4868f6591c6f ("test/crypto: add cases for raw datapath API")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Akhil Goyal <gakhil at marvell.com>
Acked-by: Declan Doherty <declan.doherty at intel.com>
Acked-by: Hemant Agrawal <hemant.agrawal at nxp.com>
Tested-by: Ruifeng Wang <ruifeng.wang at arm.com>
---
 app/test/test_cryptodev_blockcipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
index 135e57b9fa..8e168724be 100644
--- a/app/test/test_cryptodev_blockcipher.c
+++ b/app/test/test_cryptodev_blockcipher.c
@@ -160,7 +160,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
 			printf("Raw Data Path APIs do not support OOP, "
 				"Test Skipped.\n");
 			snprintf(test_msg, BLOCKCIPHER_TEST_MSG_LEN, "SKIPPED");
-			status = TEST_SUCCESS;
+			status = TEST_SKIPPED;
 			goto error_exit;
 		}
 	}
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:54:00.249545400 +0800
+++ 0144-test-crypto-fix-return-value-of-a-skipped-test.patch	2021-06-12 06:53:56.600000000 +0800
@@ -1 +1 @@
-From 085f128aac8119a3cd1b903398dc92771da4ad38 Mon Sep 17 00:00:00 2001
+From 010e63f5eefffe31c51ed79305a43bc856625824 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 085f128aac8119a3cd1b903398dc92771da4ad38 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index b99d2ce50a..411968837f 100644
+index 135e57b9fa..8e168724be 100644
@@ -26 +28 @@
-@@ -170,7 +170,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
+@@ -160,7 +160,7 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,


More information about the stable mailing list