[dpdk-stable] patch 'examples/flow_classify: fix NUMA check of port and core' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:04:02 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/110a22070f7301d8cd0c17b89dba4c72d2a08913

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 110a22070f7301d8cd0c17b89dba4c72d2a08913 Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Thu, 29 Apr 2021 08:50:46 +0800
Subject: [PATCH] examples/flow_classify: fix NUMA check of port and core
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 78a5545ef92b48553be4a244514a2514ca9b09b0 ]

According to the comments and logging, the author just hope user to use
the core and device which are in the same numa node for optimal
performance. If not, A warning gives out.

For example in flow_classify:
./build/flow_classify -a 0000:7d:00.1  -l 93
Here:
0000:7d:00.1 is on numa node 0.
core 93  is on numa node 3.

The two are not in same numa node, but no warning gives out in old codes
when device is on node 0.
This patch includes the node 0 in the check.

Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application")

Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Tested-by: Bernard Iremonger <bernard.iremonger at intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 examples/flow_classify/flow_classify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c
index 5c3e111cfa..94c1553648 100644
--- a/examples/flow_classify/flow_classify.c
+++ b/examples/flow_classify/flow_classify.c
@@ -284,7 +284,7 @@ lcore_main(struct flow_classifier *cls_app)
 	 * for best performance.
 	 */
 	RTE_ETH_FOREACH_DEV(port)
-		if (rte_eth_dev_socket_id(port) > 0 &&
+		if (rte_eth_dev_socket_id(port) >= 0 &&
 			rte_eth_dev_socket_id(port) != (int)rte_socket_id()) {
 			printf("\n\n");
 			printf("WARNING: port %u is on remote NUMA node\n",
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:54:00.337936200 +0800
+++ 0148-examples-flow_classify-fix-NUMA-check-of-port-and-co.patch	2021-06-12 06:53:56.610000000 +0800
@@ -1 +1 @@
-From 78a5545ef92b48553be4a244514a2514ca9b09b0 Mon Sep 17 00:00:00 2001
+From 110a22070f7301d8cd0c17b89dba4c72d2a08913 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 78a5545ef92b48553be4a244514a2514ca9b09b0 ]
@@ -21 +23,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list