[dpdk-stable] patch 'test: check flow classifier creation' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Sat Jun 12 01:04:05 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/9a1044da2579119ae9b163f964185352f57e235a

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 9a1044da2579119ae9b163f964185352f57e235a Mon Sep 17 00:00:00 2001
From: "Min Hu (Connor)" <humin29 at huawei.com>
Date: Thu, 22 Apr 2021 14:13:54 +0800
Subject: [PATCH] test: check flow classifier creation
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 705b04af1c100c464b6d9238408e84cfeffc489c ]

'cls->cls' will be NULL if flow classifier create has failed,
then segmentation fault will occur if the variable is used.

This patch fixed it.

Fixes: 9c9befea4f57 ("test: add flow classify unit tests")

Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Acked-by: Bernard Iremonger <bernard.iremonger at intel.com>
---
 app/test/test_flow_classify.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
index ef0b6fdd5c..951606f248 100644
--- a/app/test/test_flow_classify.c
+++ b/app/test/test_flow_classify.c
@@ -828,6 +828,12 @@ test_flow_classify(void)
 	cls_params.name = "flow_classifier";
 	cls_params.socket_id = 0;
 	cls->cls = rte_flow_classifier_create(&cls_params);
+	if (cls->cls == NULL) {
+		printf("Line %i: flow classifier create has failed!\n",
+		       __LINE__);
+		rte_free(cls);
+		return TEST_FAILED;
+	}
 
 	/* initialise ACL table params */
 	table_acl_params.n_rule_fields = RTE_DIM(ipv4_defs);
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-06-12 06:54:00.402493700 +0800
+++ 0151-test-check-flow-classifier-creation.patch	2021-06-12 06:53:56.610000000 +0800
@@ -1 +1 @@
-From 705b04af1c100c464b6d9238408e84cfeffc489c Mon Sep 17 00:00:00 2001
+From 9a1044da2579119ae9b163f964185352f57e235a Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 705b04af1c100c464b6d9238408e84cfeffc489c ]
@@ -12 +14,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list