[dpdk-stable] [PATCH 20.11 0/2] support both PIO and MMIO BAR for legacy virito device

Xueming(Steven) Li xuemingl at nvidia.com
Sun Jun 20 17:02:39 CEST 2021


Hi Huawei,

Thanks for the backport! Here is the backport policy:
https://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported

The patch set is small enough, but it changed the public PCI component, a little risky IMHO.

BTW, the patch subject seems different than upstream version, why not use upstream patch?
We are expecting a line of "[ upstream commit <id> ] at begging of path commit log.

Best Regards,
Xueming

> -----Original Message-----
> From: stable <stable-bounces at dpdk.org> On Behalf Of 谢华伟(此时此刻)
> Sent: Thursday, June 17, 2021 2:55 PM
> To: stable at dpdk.org
> Cc: david.marchand at redhat.com; maxime.coquelin at redhat.com; ferruh.yigit at intel.com; grive at u256.net; heqing.zhu at intel.com; 谢
> 华伟(此时此刻) <huawei.xhw at alibaba-inc.com>
> Subject: [dpdk-stable] [PATCH 20.11 0/2] support both PIO and MMIO BAR for legacy virito device
> 
> virtio PMD assumes legacy device only supports PIO(port-mapped) BAR resource. This is wrong. As we need to create lots of devices,
> adn PIO resource on x86 is very limited, we expose MMIO(memory-mapped I/O) BAR.
> 
> Kernel supports both PIO and MMIO BAR for legacy virtio-pci device, and for all other pci devices. This patchset handles different type
> of BAR in the similar way.
> 
> In previous implementation, under igb_uio driver we get PIO address from igb_uio sysfs entry; with uio_pci_generic, we get PIO
> address from /proc/ioports for x86, and for other ARCHs, we get PIO address from standard PCI sysfs entry. For PIO/MMIO RW, there
> is different path for different drivers and arch.
> 
> All of the above is too much twisted. This patchset unifies the way to get both PIO and MMIO address for different driver and ARCHs,
> all from standard resource attr under pci sysfs. This is most generic.
> 
> We distinguish PIO and MMIO by their address range like how kernel does.
> It is ugly but works.
> 
> huawei xie (2):
>   bus/pci: use PCI standard sysfs entry to get PIO address
>   bus/pci: support MMIO in PCI ioport accessors
> 
>  drivers/bus/pci/linux/pci.c     |  81 ---------------
>  drivers/bus/pci/linux/pci_uio.c | 214 ++++++++++++++++++++++++++++------------
>  2 files changed, 150 insertions(+), 145 deletions(-)
> 
> --
> 1.8.3.1



More information about the stable mailing list