[dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter control return value

[Zhang, Qi Z]

> -----Original Message-----
> From: dev <dev-bounces at dpdk.org> On Behalf Of Xiaozhen Ban
> Sent: Friday, March 19, 2021 12:08 PM
> To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value
> 
> > > -----Original Message-----
> > > From: Xiaozhen Ban <benhaz1024 at gmail.com>
> > > Sent: Thursday, March 18, 2021 19:44
> > > To: Guo, Jia <jia.guo at intel.com>; Wang, Haiyue <haiyue.wang at
> > > intel.com>
> > > Cc: dev at dpdk.org; stable at dpdk.org
> > > Subject: RE: RE: [PATCH] net/e1000: fix filter control return value
> > >
> > > OK, but I think this bug affects all stable release about 6 years before today.
> 
> > I don't think so, since it is PMD internal ops, the real API 'rte_flow_ops_get'
> > always use RTE_ETH_FILTER_GENERIC. ;-)
> 
> eth_igb_filter_ctrl() called by rte_eth_dev_filter_ctrl(), if application developer
> know how to use the parameter filter_type correctly, it's OK.
> otherwise he will get rte_eth_dev_filter_ctrl() return value is success but
> actually is failed.

After check with Haiyue, we think the patch is still needed for LTS <= 19.11, so

Acked-by: Qi Zhang <qi.z.zhang at intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi