[dpdk-stable] patch 'net/bnxt: mute some failure logs' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Mon May 10 18:00:07 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/f061789e7cce480726087a2315053be6e30795b7

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From f061789e7cce480726087a2315053be6e30795b7 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Wed, 10 Mar 2021 13:20:54 +0530
Subject: [PATCH] net/bnxt: mute some failure logs
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit 3740259eae2dcf0903d7e8a08909a22486be3744 ]

In the init path, driver ignores few of the HWRM command failures.
There is no need to log the error message in those cases.

Fixes: 3fb93bc7c349 ("net/bnxt: initialize parent PF information")
Fixes: 4e3f887bec4b ("net/bnxt: support HWRM port PHY qcaps")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_hwrm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index abfb4b289d..284699b2dc 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1417,7 +1417,7 @@ int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp)
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
-	HWRM_CHECK_RESULT();
+	HWRM_CHECK_RESULT_SILENT();
 
 	bp->port_cnt = resp->port_cnt;
 	if (resp->supported_speeds_auto_mode)
@@ -3245,7 +3245,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
 
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
-	HWRM_CHECK_RESULT();
+	HWRM_CHECK_RESULT_SILENT();
 
 	memcpy(bp->parent->mac_addr, resp->mac_address, RTE_ETHER_ADDR_LEN);
 	bp->parent->vnic = rte_le_to_cpu_16(resp->dflt_vnic_id);
@@ -3254,7 +3254,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
 
 	/* FIXME: Temporary workaround - remove when firmware issue is fixed. */
 	if (bp->parent->vnic == 0) {
-		PMD_DRV_LOG(ERR, "Error: parent VNIC unavailable.\n");
+		PMD_DRV_LOG(DEBUG, "parent VNIC unavailable.\n");
 		/* Use hard-coded values appropriate for current Wh+ fw. */
 		if (bp->parent->fid == 2)
 			bp->parent->vnic = 0x100;
@@ -4258,7 +4258,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)
 	req.port_id = bp->pf->port_id;
 	rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
 
-	HWRM_CHECK_RESULT();
+	HWRM_CHECK_RESULT_SILENT();
 
 	if (resp->num_leds > 0 && resp->num_leds < BNXT_MAX_LED) {
 		unsigned int i;
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-10 23:59:28.166586900 +0800
+++ 0059-net-bnxt-mute-some-failure-logs.patch	2021-05-10 23:59:26.410000000 +0800
@@ -1 +1 @@
-From 3740259eae2dcf0903d7e8a08909a22486be3744 Mon Sep 17 00:00:00 2001
+From f061789e7cce480726087a2315053be6e30795b7 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit 3740259eae2dcf0903d7e8a08909a22486be3744 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 3de5c7e3a1..e3a07314f8 100644
+index abfb4b289d..284699b2dc 100644
@@ -23 +25 @@
-@@ -1542,7 +1542,7 @@ int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp)
+@@ -1417,7 +1417,7 @@ int bnxt_hwrm_port_phy_qcaps(struct bnxt *bp)
@@ -32 +34 @@
-@@ -3385,7 +3385,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
+@@ -3245,7 +3245,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
@@ -41 +43 @@
-@@ -3394,7 +3394,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
+@@ -3254,7 +3254,7 @@ int bnxt_hwrm_parent_pf_qcfg(struct bnxt *bp)
@@ -50 +52 @@
-@@ -4398,7 +4398,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)
+@@ -4258,7 +4258,7 @@ int bnxt_hwrm_port_led_qcaps(struct bnxt *bp)


More information about the stable mailing list