[dpdk-stable] patch 'net/igc: fix Rx error counter for bad length' has been queued to stable release 20.11.2

Xueming Li xuemingl at nvidia.com
Mon May 10 18:01:29 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.2

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/fa6df61bf20ad0017eb598eaccd6df10fa8498ac

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From fa6df61bf20ad0017eb598eaccd6df10fa8498ac Mon Sep 17 00:00:00 2001
From: Alvin Zhang <alvinx.zhang at intel.com>
Date: Thu, 1 Apr 2021 13:20:43 +0800
Subject: [PATCH] net/igc: fix Rx error counter for bad length
Cc: Luca Boccassi <bluca at debian.org>

[ upstream commit c69abf624a3c84aa6b1cdfe953dcab9ff35deac2 ]

When the size of a packet in Rx channel is less than the minimum
or greater than the maximum, the packet will be simultaneously
counted by RLEC(Receive Length Error Count) and
RUC(Receive Under Size Count)/ROC(Receive Oversize Count) registers.

This patch fixes the issue of counting a length error packet twice
when counting the total number of received error packets.

Fixes: e6defdfddc3b ("net/igc: enable statistics")

Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
Acked-by: Haiyue Wang <haiyue.wang at intel.com>
---
 drivers/net/igc/igc_ethdev.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/igc/igc_ethdev.c b/drivers/net/igc/igc_ethdev.c
index 2d9bbb835d..a1152f9deb 100644
--- a/drivers/net/igc/igc_ethdev.c
+++ b/drivers/net/igc/igc_ethdev.c
@@ -1904,8 +1904,7 @@ eth_igc_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats)
 
 	/* Rx Errors */
 	rte_stats->imissed = stats->mpc;
-	rte_stats->ierrors = stats->crcerrs +
-			stats->rlec + stats->ruc + stats->roc +
+	rte_stats->ierrors = stats->crcerrs + stats->rlec +
 			stats->rxerrc + stats->algnerrc;
 
 	/* Tx Errors */
-- 
2.25.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-10 23:59:30.220166800 +0800
+++ 0141-net-igc-fix-Rx-error-counter-for-bad-length.patch	2021-05-10 23:59:26.550000000 +0800
@@ -1 +1 @@
-From c69abf624a3c84aa6b1cdfe953dcab9ff35deac2 Mon Sep 17 00:00:00 2001
+From fa6df61bf20ad0017eb598eaccd6df10fa8498ac Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Luca Boccassi <bluca at debian.org>
+
+[ upstream commit c69abf624a3c84aa6b1cdfe953dcab9ff35deac2 ]
@@ -15 +17,0 @@
-Cc: stable at dpdk.org
@@ -24 +26 @@
-index 17dd8bf8c6..31c99dca09 100644
+index 2d9bbb835d..a1152f9deb 100644


More information about the stable mailing list