[dpdk-stable] patch 'test: check thread creation' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon May 17 18:09:13 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/19/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/8cf97af50dd3b2ee44f3daba354cb80fd6ed7ae0

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 8cf97af50dd3b2ee44f3daba354cb80fd6ed7ae0 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Fri, 16 Apr 2021 16:18:26 +0800
Subject: [PATCH] test: check thread creation

[ upstream commit a20cb9d0275eb7f0618b4ef2448544056e1035df ]

There was a call for thread create function without result check.
Add result check and message print out after failure.

Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Acked-by: Reshma Pattan <reshma.pattan at intel.com>
---
 app/test/process.h | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/test/process.h b/app/test/process.h
index c3b3780337..20e8eedda8 100644
--- a/app/test/process.h
+++ b/app/test/process.h
@@ -48,6 +48,7 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
 #ifdef RTE_LIBRTE_PDUMP
 #ifdef RTE_LIBRTE_RING_PMD
 	pthread_t thread;
+	int rc;
 #endif
 #endif
 
@@ -126,8 +127,13 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
 	/* parent process does a wait */
 #ifdef RTE_LIBRTE_PDUMP
 #ifdef RTE_LIBRTE_RING_PMD
-	if ((strcmp(env_value, "run_pdump_server_tests") == 0))
-		pthread_create(&thread, NULL, &send_pkts, NULL);
+	if ((strcmp(env_value, "run_pdump_server_tests") == 0)) {
+		rc = pthread_create(&thread, NULL, &send_pkts, NULL);
+		if (rc != 0) {
+			rte_panic("Cannot start send pkts thread: %s\n",
+				  strerror(rc));
+		}
+	}
 #endif
 #endif
 
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-17 17:40:34.273204377 +0200
+++ 0124-test-check-thread-creation.patch	2021-05-17 17:40:29.351810894 +0200
@@ -1 +1 @@
-From a20cb9d0275eb7f0618b4ef2448544056e1035df Mon Sep 17 00:00:00 2001
+From 8cf97af50dd3b2ee44f3daba354cb80fd6ed7ae0 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit a20cb9d0275eb7f0618b4ef2448544056e1035df ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 27f1b1c0e6..a09a088477 100644
+index c3b3780337..20e8eedda8 100644
@@ -24,2 +25,2 @@
- #ifdef RTE_LIB_PDUMP
- #ifdef RTE_NET_RING
+ #ifdef RTE_LIBRTE_PDUMP
+ #ifdef RTE_LIBRTE_RING_PMD
@@ -33,2 +34,2 @@
- #ifdef RTE_LIB_PDUMP
- #ifdef RTE_NET_RING
+ #ifdef RTE_LIBRTE_PDUMP
+ #ifdef RTE_LIBRTE_RING_PMD


More information about the stable mailing list