[dpdk-stable] patch 'config/ppc: reduce number of cores and NUMA nodes' has been queued to stable release 19.11.9

[Christian Ehrhardt]

Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/19/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/606ef49279f68c0985efac52a85debd6589ace6d

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 606ef49279f68c0985efac52a85debd6589ace6d Mon Sep 17 00:00:00 2001
From: David Christensen <drc at linux.vnet.ibm.com>
Date: Wed, 28 Apr 2021 13:10:16 -0700
Subject: [PATCH] config/ppc: reduce number of cores and NUMA nodes

[ upstream commit 5f760b7dccd85c7da78c6e4ee3517a912861d424 ]

When setting RTE_MAX_LCORES to the maximum value supported by ppc
hardware (1536), the lcores_autotest may timeout after 30 seconds
because the test takes nearly 60 seconds to complete. Set max_lcores to
a lower value because the maximum value is unlikely to be seen in any
production systems and to eliminate the quick test timeout error.

Bugzilla ID: 684
Fixes: db1f2f8a9fe5 ("config: increase maximum lcores for ppc")

Signed-off-by: David Christensen <drc at linux.vnet.ibm.com>
Acked-by: Luca Boccassi <bluca at debian.org>
---
 config/ppc_64/meson.build | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build
index aa7d73d114..54a94d6a29 100644
--- a/config/ppc_64/meson.build
+++ b/config/ppc_64/meson.build
@@ -17,9 +17,20 @@ if not power9_supported
 	dpdk_conf.set('RTE_MACHINE','power8')
 endif
 
-# overrides specific to ppc64
-dpdk_conf.set('RTE_MAX_LCORE', 1536)
-dpdk_conf.set('RTE_MAX_NUMA_NODES', 32)
+# Certain POWER9 systems can scale as high as 1536 LCORES, but setting such a
+# high value can waste memory, cause timeouts in time limited autotests, and is
+# unlikely to be used in many production situations.  Similarly, keeping the
+# default 64 LCORES seems too small as most POWER9 dual socket systems will have
+# at least 128 LCORES available.  Set RTE_MAX_LCORE to 128 for POWER systems as
+# a compromise.
+dpdk_conf.set('RTE_MAX_LCORE', 128)
+
+# POWER systems do not allocate NUMA nodes sequentially.  A dual socket system
+# will have CPUs associated with NUMA nodes 0 & 8, so ensure that the second
+# NUMA node will be supported by setting RTE_MAX_NUMA_NODES to 16. High end
+# systems can scale even higher with as many as 32 NUMA nodes.
+dpdk_conf.set('RTE_MAX_NUMA_NODES', 16)
+
 dpdk_conf.set('RTE_CACHE_LINE_SIZE', 128)
 dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
 dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-17 17:40:35.008872208 +0200
+++ 0143-config-ppc-reduce-number-of-cores-and-NUMA-nodes.patch	2021-05-17 17:40:29.419811429 +0200
@@ -1 +1 @@
-From 5f760b7dccd85c7da78c6e4ee3517a912861d424 Mon Sep 17 00:00:00 2001
+From 606ef49279f68c0985efac52a85debd6589ace6d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 5f760b7dccd85c7da78c6e4ee3517a912861d424 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
- config/ppc/meson.build | 17 ++++++++++++++---
+ config/ppc_64/meson.build | 17 ++++++++++++++---
@@ -22,6 +23,6 @@
-diff --git a/config/ppc/meson.build b/config/ppc/meson.build
-index 1c196b8db5..4f7806bab1 100644
---- a/config/ppc/meson.build
-+++ b/config/ppc/meson.build
-@@ -17,7 +17,18 @@ if not power9_supported
-     dpdk_conf.set('RTE_MACHINE','power8')
+diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build
+index aa7d73d114..54a94d6a29 100644
+--- a/config/ppc_64/meson.build
++++ b/config/ppc_64/meson.build
+@@ -17,9 +17,20 @@ if not power9_supported
+ 	dpdk_conf.set('RTE_MACHINE','power8')
@@ -47,0 +49,2 @@
+ dpdk_conf.set('RTE_MACHINE_CPUFLAG_ALTIVEC', 1)
+ dpdk_conf.set('RTE_MACHINE_CPUFLAG_VSX', 1)