[dpdk-stable] patch 'net/hns3: fix processing link status message on PF' has been queued to stable release 19.11.9

[Christian Ehrhardt]

Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/19/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/e3f2e72800f0c7a9b2643f469c969efa969b0b85

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From e3f2e72800f0c7a9b2643f469c969efa969b0b85 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 22 Apr 2021 09:55:50 +0800
Subject: [PATCH] net/hns3: fix processing link status message on PF

[ upstream commit 4a2f6ab6fbc4be504e155a48665cc0d854ef36b6 ]

The opcode of the link status notification message reported by the
firmware is zero, it will be filtered out because driver treats it as
already processed message. As a result, the PF can't update the link
status in a timely manner.

Because only VF can set opcode to zero when processing mailbox message,
we add a judgment to make sure the PF messages will not be filtered out.

Fixes: dbbbad23e380 ("net/hns3: fix VF handling LSC event in secondary process")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/net/hns3/hns3_mbx.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index a47cb3e0ff..896ad25197 100644
--- a/drivers/net/hns3/hns3_mbx.c
+++ b/drivers/net/hns3/hns3_mbx.c
@@ -369,18 +369,21 @@ void
 hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
 {
 	struct hns3_mbx_resp_status *resp = &hw->mbx_resp;
+	struct hns3_adapter *hns = HNS3_DEV_HW_TO_ADAPTER(hw);
 	struct hns3_cmq_ring *crq = &hw->cmq.crq;
 	struct hns3_mbx_pf_to_vf_cmd *req;
 	struct hns3_cmd_desc *desc;
 	uint32_t msg_data;
 	uint16_t *msg_q;
+	bool handle_out;
 	uint8_t opcode;
 	uint16_t flag;
 	uint8_t *temp;
 	int i;
 
-	if (rte_eal_process_type() != RTE_PROC_PRIMARY ||
-	    !rte_thread_is_intr()) {
+	handle_out = (rte_eal_process_type() != RTE_PROC_PRIMARY ||
+		      !rte_thread_is_intr()) && hns->is_vf;
+	if (handle_out) {
 		/*
 		 * Currently, any threads in the primary and secondary processes
 		 * could send mailbox sync request, so it will need to process
@@ -422,7 +425,8 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
 			continue;
 		}
 
-		if (desc->opcode == 0) {
+		handle_out = hns->is_vf && desc->opcode == 0;
+		if (handle_out) {
 			/* Message already processed by other thread */
 			crq->desc[crq->next_to_use].flag = 0;
 			hns3_mbx_ring_ptr_move_crq(crq);
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-17 17:40:35.472127333 +0200
+++ 0155-net-hns3-fix-processing-link-status-message-on-PF.patch	2021-05-17 17:40:29.431811524 +0200
@@ -1 +1 @@
-From 4a2f6ab6fbc4be504e155a48665cc0d854ef36b6 Mon Sep 17 00:00:00 2001
+From e3f2e72800f0c7a9b2643f469c969efa969b0b85 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 4a2f6ab6fbc4be504e155a48665cc0d854ef36b6 ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 3b35c0277f..ba04ac9e90 100644
+index a47cb3e0ff..896ad25197 100644
@@ -27,2 +28 @@
-@@ -438,16 +438,19 @@ scan_next:
- void
+@@ -369,18 +369,21 @@ void
@@ -30,0 +31 @@
+ 	struct hns3_mbx_resp_status *resp = &hw->mbx_resp;
@@ -34,0 +36,2 @@
+ 	uint32_t msg_data;
+ 	uint16_t *msg_q;
@@ -38,2 +41,2 @@
- 
- 	rte_spinlock_lock(&hw->cmq.crq.lock);
+ 	uint8_t *temp;
+ 	int i;
@@ -49 +52 @@
-@@ -491,7 +494,8 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)
+@@ -422,7 +425,8 @@ hns3_dev_handle_mbx_msg(struct hns3_hw *hw)