[dpdk-stable] patch 'net/bonding: fix leak on remove' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon May 17 18:09:46 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/19/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/8dc5c2029fabae40938f99ef2cdd83bd4bad9cf4

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 8dc5c2029fabae40938f99ef2cdd83bd4bad9cf4 Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Thu, 22 Apr 2021 10:05:02 +0800
Subject: [PATCH] net/bonding: fix leak on remove

[ upstream commit 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb ]

If the bond device was created by vdev mode, the kvlist was not free
when the bond device removed.

Fixes: 8d30fe7fa737 ("bonding: support port hotplug")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 drivers/net/bonding/rte_eth_bond_pmd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index e7cb418053..68cf5fef69 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -3447,6 +3447,8 @@ bond_remove(struct rte_vdev_device *dev)
 	rte_bitmap_free(internals->vlan_filter_bmp);
 	rte_free(internals->vlan_filter_bmpmem);
 
+	if (internals->kvlist != NULL)
+		rte_kvargs_free(internals->kvlist);
 	rte_eth_dev_release_port(eth_dev);
 
 	return 0;
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-17 17:40:35.545098144 +0200
+++ 0157-net-bonding-fix-leak-on-remove.patch	2021-05-17 17:40:29.435811555 +0200
@@ -1 +1 @@
-From 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb Mon Sep 17 00:00:00 2001
+From 8dc5c2029fabae40938f99ef2cdd83bd4bad9cf4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 144dc4739975602eec9f8c5f33d1a1bb7df7fcdb ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 2e9cea5b8e..25b1f771a1 100644
+index e7cb418053..68cf5fef69 100644
@@ -23,4 +24,4 @@
-@@ -3467,6 +3467,8 @@ bond_remove(struct rte_vdev_device *dev)
- 		ret = bond_ethdev_stop(eth_dev);
- 		bond_ethdev_close(eth_dev);
- 	}
+@@ -3447,6 +3447,8 @@ bond_remove(struct rte_vdev_device *dev)
+ 	rte_bitmap_free(internals->vlan_filter_bmp);
+ 	rte_free(internals->vlan_filter_bmpmem);
+ 
@@ -31 +32 @@
- 	return ret;
+ 	return 0;


More information about the stable mailing list