[dpdk-stable] patch 'net/i40e: remove redundant VSI check in Tx queue setup' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon May 17 18:09:55 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/19/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/5d83c381faf1e069752f7edbf801c159a352e6df

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 5d83c381faf1e069752f7edbf801c159a352e6df Mon Sep 17 00:00:00 2001
From: Chengwen Feng <fengchengwen at huawei.com>
Date: Wed, 21 Apr 2021 10:33:14 +0800
Subject: [PATCH] net/i40e: remove redundant VSI check in Tx queue setup

[ upstream commit 70077b8630011e3cd5d7a2fa9af6ea6e73e46a4d ]

The VSI pointer is always valid, so there is no need to judge its
validity.

Fixes: b6583ee40265 ("i40e: full VMDQ pools support")

Signed-off-by: Chengwen Feng <fengchengwen at huawei.com>
Signed-off-by: Min Hu (Connor) <humin29 at huawei.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/i40e/i40e_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 352fb426df..4dc828357f 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2186,8 +2186,6 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 	if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
 		vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 		vsi = &vf->vsi;
-		if (!vsi)
-			return -EINVAL;
 		reg_idx = queue_idx;
 	} else {
 		pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-17 17:40:35.914928925 +0200
+++ 0166-net-i40e-remove-redundant-VSI-check-in-Tx-queue-setu.patch	2021-05-17 17:40:29.487811965 +0200
@@ -1 +1 @@
-From 70077b8630011e3cd5d7a2fa9af6ea6e73e46a4d Mon Sep 17 00:00:00 2001
+From 5d83c381faf1e069752f7edbf801c159a352e6df Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 70077b8630011e3cd5d7a2fa9af6ea6e73e46a4d ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 86a9eae370..02cf5e787c 100644
+index 352fb426df..4dc828357f 100644
@@ -23 +24 @@
-@@ -2253,8 +2253,6 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
+@@ -2186,8 +2186,6 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,


More information about the stable mailing list