[dpdk-stable] patch 'net/bnxt: prevent device access in error state' has been queued to stable release 19.11.9

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon May 17 18:21:13 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/19/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/741a4e8fca9cadcb5b3fbb7fdaeed139577d8792

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 741a4e8fca9cadcb5b3fbb7fdaeed139577d8792 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Mon, 3 May 2021 10:51:50 +0530
Subject: [PATCH] net/bnxt: prevent device access in error state

[ upstream commit c967098a4c0aafa0cb244ab9423fdea3d943d1ab ]

Driver should prevent any DMA with the device when it
detects an error. When firmware is in fatal state,
stop tx/rx by assigning them to dummy functions.

Fixes: be14720def9c ("net/bnxt: support FW reset")
Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur at broadcom.com>
Reviewed-by: Andy Gospodarek <gospo at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 60e85c33f1..524764e1f7 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -4300,6 +4300,8 @@ reset:
 	bp->flags |= BNXT_FLAG_FATAL_ERROR;
 	bp->flags |= BNXT_FLAG_FW_RESET;
 
+	bnxt_stop_rxtx(bp);
+
 	PMD_DRV_LOG(ERR, "Detected FW dead condition\n");
 
 	if (bnxt_is_master_func(bp))
-- 
2.31.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-05-17 17:40:37.125203550 +0200
+++ 0198-net-bnxt-prevent-device-access-in-error-state.patch	2021-05-17 17:40:29.575812657 +0200
@@ -1 +1 @@
-From c967098a4c0aafa0cb244ab9423fdea3d943d1ab Mon Sep 17 00:00:00 2001
+From 741a4e8fca9cadcb5b3fbb7fdaeed139577d8792 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit c967098a4c0aafa0cb244ab9423fdea3d943d1ab ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index 719eb68847..822853a008 100644
+index 60e85c33f1..524764e1f7 100644
@@ -26 +27 @@
-@@ -4275,6 +4275,8 @@ reset:
+@@ -4300,6 +4300,8 @@ reset:


More information about the stable mailing list