[dpdk-stable] [dpdk-dev] [EXT] Re: [PATCH v2] examples/ipsec-secgw: fix potential build error

[David Marchand]

On Wed, Nov 3, 2021 at 2:45 PM Akhil Goyal <gakhil at marvell.com> wrote:
>
> > On Wed, Nov 3, 2021 at 2:09 PM Thomas Monjalon <thomas at monjalon.net>
> > wrote:
> > >
> > > 03/11/2021 12:56, Radu Nicolau:
> > > > When STATS_INTERVAL is set to a non-zero value the core_statistics array
> > > > will be defined in multiple compilation units and this can trigger a
> > > > linker error on particular environments. In order to fix this the
> > > > core_statistics definition was moved out of the header file.
> > >
> > > So it is not fixing compilation,
> > > as we would never apply a patch which would completely break
> > compilation.
> > > I would say (in the title) that it moves global variable from header file.
> > >
> > > > Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet
> > statistics")
> > > > Cc: stable at dpdk.org
> > > >
> > > > Signed-off-by: Radu Nicolau <radu.nicolau at intel.com>
> >
> > I guess it has to do with series:
> > https://patchwork.dpdk.org/project/dpdk/list/?series=20174
>
> Yes this series initiated the issue, applying both the patch and the series now
> On next-crypto

It means a patch of this series broke compilation, and this fix here
should be squashed in it.


-- 
David Marchand