[dpdk-stable] [PATCH] eventdev/eth_tx: fix queue_del function

[Jayatheerthan, Jay]

+ David Marchand, who reported this issue.

The change looks good to me. You can add my ack.

> -----Original Message-----
> From: Naga Harish K, S V <s.v.naga.harish.k at intel.com>
> Sent: Tuesday, November 9, 2021 1:04 PM
> To: jerinj at marvell.com; Jayatheerthan, Jay <jay.jayatheerthan at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org
> Subject: [PATCH] eventdev/eth_tx: fix queue_del function
> 
> This patch fixes heap-use-after-free reported by ASAN,
> please reference https://bugs.dpdk.org/show_bug.cgi?id=869
> 
> The application can use the queue_id as `-1` to delete all
> the queues of the eth_device that are added to tx_adapter
> instance.
> In above case, the queue_del api is trying to use number of
> queues from adapter level instead of eth_device queues.
> When there are queues added from multiple eth devices,
> it will result in heap-use-after-free as reported by ASAN.
> 
> This patch fixes the queue_del api to use correct number of
> queues.
> 
> Bugzilla ID: 869
> Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Naga Harish K S V <s.v.naga.harish.k at intel.com>
> ---
>  lib/eventdev/rte_event_eth_tx_adapter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
> index da55d2c2dc..c17f33f098 100644
> --- a/lib/eventdev/rte_event_eth_tx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_tx_adapter.c
> @@ -864,7 +864,7 @@ txa_service_queue_del(uint8_t id,
>  		uint16_t i, q, nb_queues;
>  		int ret = 0;
> 
> -		nb_queues = txa->nb_queues;
> +		nb_queues = txa->txa_ethdev[port_id].nb_queues;
>  		if (nb_queues == 0)
>  			return 0;
> 
> --
> 2.25.1