[dpdk-stable] patch 'examples/fips_validation: fix resetting pointer' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Wed Nov 10 07:30:00 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/de983dfa6d961e92bbdf0abdd415ed15abd6331a

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From de983dfa6d961e92bbdf0abdd415ed15abd6331a Mon Sep 17 00:00:00 2001
From: Ciara Power <ciara.power at intel.com>
Date: Thu, 12 Aug 2021 14:24:35 +0000
Subject: [PATCH] examples/fips_validation: fix resetting pointer
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 15bb59a5ebb7fdf4de18fdf11ba2f9b3a8ee9c32 ]

The env.digest memory was freed, but the pointer was not set to NULL
afterwards. This caused an "Invalid Memory" error, as the pointer tries
to free twice.

Fixes: 952e10cdad5e ("examples/fips_validation: support scatter gather list")

Signed-off-by: Ciara Power <ciara.power at intel.com>
Acked-by: Fan Zhang <roy.fan.zhang at intel.com>
---
 examples/fips_validation/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index cb38d40b66..dee9272880 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1828,8 +1828,10 @@ error_one_case:
 
 	fips_test_clear();
 
-	if (env.digest)
+	if (env.digest) {
 		rte_free(env.digest);
+		env.digest = NULL;
+	}
 	if (env.mbuf)
 		rte_pktmbuf_free(env.mbuf);
 
-- 
2.33.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-10 14:17:07.139566073 +0800
+++ 0116-examples-fips_validation-fix-resetting-pointer.patch	2021-11-10 14:17:01.880746009 +0800
@@ -1 +1 @@
-From 15bb59a5ebb7fdf4de18fdf11ba2f9b3a8ee9c32 Mon Sep 17 00:00:00 2001
+From de983dfa6d961e92bbdf0abdd415ed15abd6331a Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 15bb59a5ebb7fdf4de18fdf11ba2f9b3a8ee9c32 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index c0e68b8848..b0de3d269a 100644
+index cb38d40b66..dee9272880 100644
@@ -23 +25 @@
-@@ -1843,8 +1843,10 @@ error_one_case:
+@@ -1828,8 +1828,10 @@ error_one_case:


More information about the stable mailing list