[dpdk-stable] patch 'devtools: fix letter case check in commit title' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Wed Nov 10 07:30:57 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/04cc709c6aa097552ed270314cd8d898a51dac6f

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 04cc709c6aa097552ed270314cd8d898a51dac6f Mon Sep 17 00:00:00 2001
From: Thomas Monjalon <thomas at monjalon.net>
Date: Mon, 18 Oct 2021 11:55:58 +0200
Subject: [PATCH] devtools: fix letter case check in commit title
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 8b51fbc09e44ceaca0d32139bbc558d8cd5d06dd ]

The prefix (before the colon) of the title is lowercase.
The check of uppercase/lowercase in the commit title
was supposed to apply after the colon,
but some greps were not limited to the exact word.
So in the case of "test/dma: add basic dmadev instance tests",
the lowercase word "dmadev" was wrongly suggested to be uppercase.

The words of the dictionary must be filtered as whole word
with the grep option -w.

Fixes: d448efa259e9 ("devtools: export dictionary for commit title check")

Signed-off-by: Thomas Monjalon <thomas at monjalon.net>
---
 devtools/check-git-log.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/devtools/check-git-log.sh b/devtools/check-git-log.sh
index 9988bf863d..885d444b3d 100755
--- a/devtools/check-git-log.sh
+++ b/devtools/check-git-log.sh
@@ -111,12 +111,12 @@ IFS='
 '
 words="$selfdir/words-case.txt"
 for word in $(cat $words); do
-	bad=$(echo "$headlines" | grep -iw $word | grep -v $word)
+	bad=$(echo "$headlines" | grep -iw $word | grep -vw $word)
 	if [ "$word" = "Tx" ]; then
 		bad=$(echo $bad | grep -v 'OCTEON\ TX')
 	fi
 	for bad_line in $bad; do
-		bad_word=$(echo $bad_line | cut -d":" -f2 | grep -io $word)
+		bad_word=$(echo $bad_line | cut -d":" -f2 | grep -iwo $word)
 		[ -z "$bad_word" ] || { printf "Wrong headline case:\n\
 			\"$bad_line\": $bad_word --> $word\n" && failure=true;}
 	done
-- 
2.33.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-10 14:17:09.619241935 +0800
+++ 0173-devtools-fix-letter-case-check-in-commit-title.patch	2021-11-10 14:17:01.984078497 +0800
@@ -1 +1 @@
-From 8b51fbc09e44ceaca0d32139bbc558d8cd5d06dd Mon Sep 17 00:00:00 2001
+From 04cc709c6aa097552ed270314cd8d898a51dac6f Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 8b51fbc09e44ceaca0d32139bbc558d8cd5d06dd ]
@@ -17 +19,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list