[dpdk-stable] patch 'test/compress-perf: remove unused variable' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Wed Nov 10 07:31:56 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/046835a080e15ccfba08a2f69264da9862732420

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 046835a080e15ccfba08a2f69264da9862732420 Mon Sep 17 00:00:00 2001
From: Jim Harris <james.r.harris at intel.com>
Date: Fri, 29 Oct 2021 17:16:22 +0000
Subject: [PATCH] test/compress-perf: remove unused variable
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit 1345c5baae35d16b20126704c8636c476c4f32eb ]

clang-13 rightfully complains that the total_deq_ops
variable in cperf_cyclecount_op_setup is set but not
used, since the final accumulated total_deq_ops
results isn't used anywhere. So just remove the
total_deq_ops variable.

Fixes: 2695db95a147 ("test/compress: add cycle-count mode to perf tool")

Signed-off-by: Jim Harris <james.r.harris at intel.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
 app/test-compress-perf/comp_perf_test_cyclecount.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/app/test-compress-perf/comp_perf_test_cyclecount.c b/app/test-compress-perf/comp_perf_test_cyclecount.c
index 55559a7d5a..c875ddbdac 100644
--- a/app/test-compress-perf/comp_perf_test_cyclecount.c
+++ b/app/test-compress-perf/comp_perf_test_cyclecount.c
@@ -76,7 +76,6 @@ cperf_cyclecount_op_setup(struct rte_comp_op **ops,
 
 	for (iter = 0; iter < num_iter; iter++) {
 		uint32_t remaining_ops = mem->total_bufs;
-		uint32_t total_deq_ops = 0;
 		uint32_t total_enq_ops = 0;
 		uint16_t num_enq = 0;
 		uint16_t num_deq = 0;
@@ -136,7 +135,6 @@ cperf_cyclecount_op_setup(struct rte_comp_op **ops,
 			/* instead of the real dequeue operation */
 			num_deq = num_ops;
 
-			total_deq_ops += num_deq;
 			rte_mempool_put_bulk(mem->op_pool,
 					     (void **)ops, num_deq);
 		}
-- 
2.33.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-10 14:17:12.126585122 +0800
+++ 0232-test-compress-perf-remove-unused-variable.patch	2021-11-10 14:17:02.064077842 +0800
@@ -1 +1 @@
-From 1345c5baae35d16b20126704c8636c476c4f32eb Mon Sep 17 00:00:00 2001
+From 046835a080e15ccfba08a2f69264da9862732420 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit 1345c5baae35d16b20126704c8636c476c4f32eb ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list