patch 'net/iavf: fix pointer of meta data' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Sun Nov 28 15:53:17 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/30/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/712ace31c574c287538d606f108ffd7400464214

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From 712ace31c574c287538d606f108ffd7400464214 Mon Sep 17 00:00:00 2001
From: Alvin Zhang <alvinx.zhang at intel.com>
Date: Thu, 11 Nov 2021 14:31:47 +0800
Subject: [PATCH] net/iavf: fix pointer of meta data
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit f96789aeaf1851071f5b2ab532d7687c66e1ee41 ]

This patch fixes coverity issue by directly passing the address
of the meta data to lower function.

Coverity issue: 373867
Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")

Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
Acked-by: Qi Zhang <qi.z.zhang at intel.com>
---
 drivers/net/iavf/iavf_hash.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c
index 72b0117230..eb7fd3f66f 100644
--- a/drivers/net/iavf/iavf_hash.c
+++ b/drivers/net/iavf/iavf_hash.c
@@ -901,10 +901,9 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
 static int
 iavf_hash_parse_action(struct iavf_pattern_match_item *match_item,
 		       const struct rte_flow_action actions[],
-		       uint64_t pattern_hint, void **meta,
+		       uint64_t pattern_hint, struct iavf_rss_meta *rss_meta,
 		       struct rte_flow_error *error)
 {
-	struct iavf_rss_meta *rss_meta = (struct iavf_rss_meta *)*meta;
 	struct virtchnl_proto_hdrs *proto_hdrs;
 	enum rte_flow_action_type action_type;
 	const struct rte_flow_action_rss *rss;
@@ -1018,7 +1017,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad,
 		goto error;
 
 	ret = iavf_hash_parse_action(pattern_match_item, actions, phint,
-				     (void **)&rss_meta_ptr, error);
+				     rss_meta_ptr, error);
 
 error:
 	if (!ret && meta)
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-28 22:41:04.209479880 +0800
+++ 0013-net-iavf-fix-pointer-of-meta-data.patch	2021-11-28 22:41:03.220209457 +0800
@@ -1 +1 @@
-From f96789aeaf1851071f5b2ab532d7687c66e1ee41 Mon Sep 17 00:00:00 2001
+From 712ace31c574c287538d606f108ffd7400464214 Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit f96789aeaf1851071f5b2ab532d7687c66e1ee41 ]
@@ -11 +13,0 @@
-Cc: stable at dpdk.org
@@ -20 +22 @@
-index 55d8a11da3..5e0888ea68 100644
+index 72b0117230..eb7fd3f66f 100644
@@ -23 +25 @@
-@@ -1261,10 +1261,9 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
+@@ -901,10 +901,9 @@ iavf_any_invalid_rss_type(enum rte_eth_hash_function rss_func,
@@ -35 +37 @@
-@@ -1378,7 +1377,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad,
+@@ -1018,7 +1017,7 @@ iavf_hash_parse_pattern_action(__rte_unused struct iavf_adapter *ad,


More information about the stable mailing list