patch 'vdpa/mlx5: fix mkey creation check' has been queued to stable release 20.11.4

Xueming Li xuemingl at nvidia.com
Sun Nov 28 15:53:47 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/30/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/steevenlee/dpdk

This queued commit can be viewed at:
https://github.com/steevenlee/dpdk/commit/bc9ea21f705e5c0b66b9e187e92b24b38fddabfd

Thanks.

Xueming Li <xuemingl at nvidia.com>

---
>From bc9ea21f705e5c0b66b9e187e92b24b38fddabfd Mon Sep 17 00:00:00 2001
From: Bing Zhao <bingz at nvidia.com>
Date: Fri, 12 Nov 2021 16:42:45 +0200
Subject: [PATCH] vdpa/mlx5: fix mkey creation check
Cc: Xueming Li <xuemingl at nvidia.com>

[ upstream commit e9511a26e1c4fed566c3c2ea33ca895b7ab4f724 ]

The return value of "mlx5_os_wrapped_mkey_create" is checked in the
caller. A zero means success without any error.

The typo in the if-condition should be fixed in case there is a
misjudgment.

Fixes: 398ea8450c53 ("vdpa/mlx5: workaround dirty bitmap MR creation")

Signed-off-by: Bing Zhao <bingz at nvidia.com>
Acked-by: Matan Azrad <matan at nvidia.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
---
 drivers/vdpa/mlx5/mlx5_vdpa_lm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
index 49d74a7e99..bb5bd3b887 100644
--- a/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
+++ b/drivers/vdpa/mlx5/mlx5_vdpa_lm.c
@@ -47,7 +47,7 @@ mlx5_vdpa_dirty_bitmap_set(struct mlx5_vdpa_priv *priv, uint64_t log_base,
 					      (void *)(uintptr_t)log_base,
 					      log_size, &priv->lm_mr);
 
-	if (!ret) {
+	if (ret) {
 		DRV_LOG(ERR, "Failed to allocate wrapped MR for lm.");
 		return -1;
 	}
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-28 22:41:05.566180945 +0800
+++ 0043-vdpa-mlx5-fix-mkey-creation-check.patch	2021-11-28 22:41:03.323540920 +0800
@@ -1 +1 @@
-From e9511a26e1c4fed566c3c2ea33ca895b7ab4f724 Mon Sep 17 00:00:00 2001
+From bc9ea21f705e5c0b66b9e187e92b24b38fddabfd Mon Sep 17 00:00:00 2001
@@ -4,0 +5,3 @@
+Cc: Xueming Li <xuemingl at nvidia.com>
+
+[ upstream commit e9511a26e1c4fed566c3c2ea33ca895b7ab4f724 ]
@@ -13 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +25 @@
-index e65e4faa47..43a2b98255 100644
+index 49d74a7e99..bb5bd3b887 100644


More information about the stable mailing list