patch 'power: fix build with clang 13' has been queued to stable release 19.11.11

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Tue Nov 30 17:35:33 CET 2021


Hi,

FYI, your patch has been queued to stable release 19.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before December 10th 2021. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/3cc36e068b4298160caa9e77c5545bd8f8e019f6

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 3cc36e068b4298160caa9e77c5545bd8f8e019f6 Mon Sep 17 00:00:00 2001
From: Jim Harris <james.r.harris at intel.com>
Date: Fri, 5 Nov 2021 15:53:51 +0000
Subject: [PATCH] power: fix build with clang 13

[ upstream commit 0353121c33846c40ff2e2282448f324c93d3ce9d ]

clang-13 rightfully complains that the tot_ppi variable in update_stats
is set but not used, since the final accumulated tot_ppi results isn't
used anywhere.

Fixes: 450f0791312c ("power: add traffic pattern aware power control")

Signed-off-by: Jim Harris <james.r.harris at intel.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
 lib/librte_power/rte_power_empty_poll.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c
index 0a8024ddca..6aa5a5735f 100644
--- a/lib/librte_power/rte_power_empty_poll.c
+++ b/lib/librte_power/rte_power_empty_poll.c
@@ -207,7 +207,7 @@ update_training_stats(struct priority_worker *poll_stats,
 static inline uint32_t __attribute__((always_inline))
 update_stats(struct priority_worker *poll_stats)
 {
-	uint64_t tot_edpi = 0, tot_ppi = 0;
+	uint64_t tot_edpi = 0;
 	uint32_t j, percent;
 
 	struct priority_worker *s = poll_stats;
@@ -237,7 +237,6 @@ update_stats(struct priority_worker *poll_stats)
 
 	for (j = 0; j < BINS_AV; j++) {
 		tot_edpi += s->edpi_av[j];
-		tot_ppi += s->ppi_av[j];
 	}
 
 	tot_edpi = tot_edpi / BINS_AV;
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-30 16:50:13.444869755 +0100
+++ 0129-power-fix-build-with-clang-13.patch	2021-11-30 16:50:05.966874821 +0100
@@ -1 +1 @@
-From 0353121c33846c40ff2e2282448f324c93d3ce9d Mon Sep 17 00:00:00 2001
+From 3cc36e068b4298160caa9e77c5545bd8f8e019f6 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0353121c33846c40ff2e2282448f324c93d3ce9d ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- lib/power/rte_power_empty_poll.c | 3 +--
+ lib/librte_power/rte_power_empty_poll.c | 3 +--
@@ -19,4 +20,4 @@
-diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c
-index 975aa92997..8a2d60c576 100644
---- a/lib/power/rte_power_empty_poll.c
-+++ b/lib/power/rte_power_empty_poll.c
+diff --git a/lib/librte_power/rte_power_empty_poll.c b/lib/librte_power/rte_power_empty_poll.c
+index 0a8024ddca..6aa5a5735f 100644
+--- a/lib/librte_power/rte_power_empty_poll.c
++++ b/lib/librte_power/rte_power_empty_poll.c
@@ -24 +25 @@
- static __rte_always_inline uint32_t
+ static inline uint32_t __attribute__((always_inline))


More information about the stable mailing list