patch 'event/sw: remove unused inflight events count' has been queued to stable release 19.11.11

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Tue Nov 30 17:35:39 CET 2021


Hi,

FYI, your patch has been queued to stable release 19.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before December 10th 2021. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/0f5f1767a166ac516cfc2b3439f90512eb5ae685

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 0f5f1767a166ac516cfc2b3439f90512eb5ae685 Mon Sep 17 00:00:00 2001
From: Conor Walsh <conor.walsh at intel.com>
Date: Mon, 15 Nov 2021 17:58:53 +0000
Subject: [PATCH] event/sw: remove unused inflight events count

[ upstream commit 0f66d415c467daa1a41bb5184d72e61980c8991b ]

Reported by clang 13.
This patch removes the inflights variable from the sw_dump function
within the software section of the event driver as it is an unused but
set variable.

Bugzilla ID: 881
Fixes: c66baa68e453 ("event/sw: add dump function for easier debugging")

Reported-by: Liang Longfeng <longfengx.liang at intel.com>
Signed-off-by: Conor Walsh <conor.walsh at intel.com>
Acked-by: Harry van Haaren <harry.van.haaren at intel.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
 drivers/event/sw/sw_evdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
index fb8e8bebbb..d075108610 100644
--- a/drivers/event/sw/sw_evdev.c
+++ b/drivers/event/sw/sw_evdev.c
@@ -717,7 +717,6 @@ sw_dump(struct rte_eventdev *dev, FILE *f)
 			continue;
 		}
 		int affinities_per_port[SW_PORTS_MAX] = {0};
-		uint32_t inflights = 0;
 
 		fprintf(f, "  Queue %d (%s)\n", i, q_type_strings[qid->type]);
 		fprintf(f, "\trx   %"PRIu64"\tdrop %"PRIu64"\ttx   %"PRIu64"\n",
@@ -738,7 +737,6 @@ sw_dump(struct rte_eventdev *dev, FILE *f)
 		for (flow = 0; flow < RTE_DIM(qid->fids); flow++)
 			if (qid->fids[flow].cq != -1) {
 				affinities_per_port[qid->fids[flow].cq]++;
-				inflights += qid->fids[flow].pcount;
 			}
 
 		uint32_t port;
-- 
2.34.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-11-30 16:50:13.747135766 +0100
+++ 0135-event-sw-remove-unused-inflight-events-count.patch	2021-11-30 16:50:05.974874880 +0100
@@ -1 +1 @@
-From 0f66d415c467daa1a41bb5184d72e61980c8991b Mon Sep 17 00:00:00 2001
+From 0f5f1767a166ac516cfc2b3439f90512eb5ae685 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 0f66d415c467daa1a41bb5184d72e61980c8991b ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 070a4802e9..fa72ceb949 100644
+index fb8e8bebbb..d075108610 100644
@@ -27 +28 @@
-@@ -711,7 +711,6 @@ sw_dump(struct rte_eventdev *dev, FILE *f)
+@@ -717,7 +717,6 @@ sw_dump(struct rte_eventdev *dev, FILE *f)
@@ -35 +36 @@
-@@ -732,7 +731,6 @@ sw_dump(struct rte_eventdev *dev, FILE *f)
+@@ -738,7 +737,6 @@ sw_dump(struct rte_eventdev *dev, FILE *f)


More information about the stable mailing list