[dpdk-stable] [PATCH v3 5/5] app/testpmd: add missing flow types in port info

[Maxime Coquelin]

Hi Xiaoyun,

On 9/30/21 03:05, Li, Xiaoyun wrote:
> Hi
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin at redhat.com>
>> Sent: Wednesday, September 29, 2021 17:17
>> To: dev at dpdk.org; Xia, Chenbo <chenbo.xia at intel.com>;
>> amorenoz at redhat.com; david.marchand at redhat.com;
>> andrew.rybchenko at oktetlabs.ru; Yigit, Ferruh <ferruh.yigit at intel.com>;
>> michaelba at nvidia.com; viacheslavo at nvidia.com; Li, Xiaoyun
>> <xiaoyun.li at intel.com>
>> Cc: stable at dpdk.org; nelio.laranjeiro at 6wind.com; yvugenfi at redhat.com;
>> ybendito at redhat.com; Maxime Coquelin <maxime.coquelin at redhat.com>
>> Subject: [PATCH v3 5/5] app/testpmd: add missing flow types in port info
>>
>> This patch adds missing IPv6-Ex and GPTU flow types to port info command.
> 
> GTPU not GPTU
> 
>> It also add the same definitions to str2flowtype(), used to configure flow
>> director.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
>> ---
>>   app/test-pmd/cmdline.c | 4 ++++
>>   app/test-pmd/config.c  | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>> a9efd027c3..259d9cee4e 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -10408,6 +10408,10 @@ str2flowtype(char *string)
>>   		{"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP},
>>   		{"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER},
>>   		{"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD},
>> +		{"ipv6-ex", RTE_ETH_FLOW_IPV6_EX},
>> +		{"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX},
>> +		{"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX},
>> +		{"gptu", RTE_ETH_FLOW_GTPU},
> 
> "gtpu"
> 
>>   	};
>>
>>   	for (i = 0; i < RTE_DIM(flowtype_str); i++) { diff --git a/app/test-
>> pmd/config.c b/app/test-pmd/config.c index 9a4a0c232b..39deb02950
>> 100644
>> --- a/app/test-pmd/config.c
>> +++ b/app/test-pmd/config.c
>> @@ -4528,11 +4528,15 @@ flowtype_to_str(uint16_t flow_type)
>>   		{"ipv6-sctp", RTE_ETH_FLOW_NONFRAG_IPV6_SCTP},
>>   		{"ipv6-other", RTE_ETH_FLOW_NONFRAG_IPV6_OTHER},
>>   		{"l2_payload", RTE_ETH_FLOW_L2_PAYLOAD},
>> +		{"ipv6-ex", RTE_ETH_FLOW_IPV6_EX},
>> +		{"ipv6-tcp-ex", RTE_ETH_FLOW_IPV6_TCP_EX},
>> +		{"ipv6-udp-ex", RTE_ETH_FLOW_IPV6_UDP_EX},
>>   		{"port", RTE_ETH_FLOW_PORT},
>>   		{"vxlan", RTE_ETH_FLOW_VXLAN},
>>   		{"geneve", RTE_ETH_FLOW_GENEVE},
>>   		{"nvgre", RTE_ETH_FLOW_NVGRE},
>>   		{"vxlan-gpe", RTE_ETH_FLOW_VXLAN_GPE},
>> +		{"gptu", RTE_ETH_FLOW_GTPU},
> 
> "gtpu"
> 
>>   	};
>>
>>   	for (i = 0; i < RTE_DIM(flowtype_str_table); i++) {
>> --
>> 2.31.1
> 

Oops, looks like I really want to rename this protocol.
If there are not other comments on the series, I can fix while applying
if this is OK for you.

Thanks,
Maxime