[dpdk-stable] [dpdk-dev] [PATCH] build: propagate Windows system dependencies to pkg-config

[Thomas Monjalon]

20/08/2021 18:08, William Tu:
> On Thu, Aug 19, 2021 at 4:15 PM Dmitry Kozlyuk <dmitry.kozliuk at gmail.com> wrote:
> >
> > Windows EAL depends on some system libraries. They were linked using
> > add_project_link_arguments('-l<LIB>'), which prevented meson from adding
> > them to Libs.private of pkg-config file. As a result, applications using
> > pkg-config to find DPDK hit link errors, for example:
> >
> >     librte_eal.a(eal_windows_eal_debug.c.obj) : error LNK2019: unresolved
> >     external symbol __imp_SymInitialize referenced in function
> >     rte_dump_stack
> >
> > Reference required libraries in EAL using ext_deps meson variable.
> > bus/pci and net/pcap depend on lib/eal and will pull them automatically.
> > Drop advapi32 dependency, as MinGW locates VirtualAlloc2() dynamically.
> >
> > Fixes: 2a5d547a4a9b ("eal/windows: implement basic memory management")
> > Fixes: c91717eb75c8 ("eal/windows: support exit and panic")
> > Cc: talshn at nvidia.com
> > Cc: stable at dpdk.org
> >
> > Reported-by: William Tu <u9012063 at gmail.com>
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk at gmail.com>
> > ---
> 
> Thanks for the fix.
> I've tested on my Windows environment and it works ok.
> the libdpdk.pc shows the required libraries.
> 
> Acked-by: William Tu <u9012063 at gmail.com>

Converted to Tested-by.

Applied, thanks