[dpdk-stable] [PATCH] bus/pci: fix numa node return value
Varghese, Vipin
vipin.varghese at intel.com
Fri Sep 24 11:13:51 CEST 2021
Hi Pallavi,
Assuming the intention is set SOCKET_ID_ANY for faulty cases, couple of observation. In Linux
```
if (access(filename, F_OK) != -1) {
if (eal_parse_sysfs_value(filename, &tmp) == 0)
dev->device.numa_node = tmp;
else
dev->device.numa_node = -1;
} else {
dev->device.numa_node = 0;
}
```
[snipped]
> @@ -243,7 +244,7 @@ get_device_resource_info(HDEVINFO dev_info,
> DWORD error = GetLastError();
Set the default value as ` dev->device.numa_node = SOCKET_ID_ANY;`
> if (error == ERROR_NOT_FOUND) {
> /* On older CPUs, NUMA is not bound to PCIe
> locality. */
> - dev->device.numa_node = 0;
> + dev->device.numa_node = SOCKET_ID_ANY;
If the API is unsuccessful for ` ERROR_NOT_FOUND ` then you can set it to `0` (as recommened in documentation)
> return ERROR_SUCCESS;
> }
> RTE_LOG_WIN32_ERR("SetupDiGetDevicePropertyW"
Else if if it other errors it will ` SOCKET_ID_ANY`.
> --
> 2.31.1.windows.1
More information about the stable
mailing list