[PATCH v2] test/bpf: skip test if libpcap is unavailable

Tyler Retzlaff roretzla at linux.microsoft.com
Tue Apr 26 09:47:20 CEST 2022


On Tue, Apr 26, 2022 at 09:41:08AM +0200, David Marchand wrote:
> On Tue, Mar 22, 2022 at 8:12 AM Tyler Retzlaff
> <roretzla at linux.microsoft.com> wrote:
> >
> > test_bpf_convert is being conditionally registered depending on the
> > presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a
> > test to run.
> >
> > when the UT runs test_bpf_convert test-dpdk can't find the registration
> > and assumes the DPDK_TEST environment variable hasn't been defined
> > resulting in test-dpdk dropping to interactive mode and subsequently
> > waiting for the remainder of the UT fast-test timeout period before
> > reporting the test as having timed out.
> >
> > * unconditionally register test_bpf_convert
> > * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the
> >   test is skipped similar to that done with the test_bpf test.
> >
> > Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Tyler Retzlaff <roretzla at linux.microsoft.com>
> Acked-by: Stephen Hemminger <stephen at networkplumber.org>
> Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
> 
> Applied, thanks.

thanks mate!

> 
> 
> -- 
> David Marchand


More information about the stable mailing list