[PATCH 19.11] net/iavf: fix Rx queue interrupt setting

[Christian Ehrhardt]

On Wed, Aug 3, 2022 at 1:40 PM Ali Alnubani <alialnu at nvidia.com> wrote:
>
> > -----Original Message-----
> > From: Christian Ehrhardt <christian.ehrhardt at canonical.com>
> > Sent: Wednesday, August 3, 2022 12:58 PM
> > To: Ke Zhang <ke1x.zhang at intel.com>
> > Cc: stable at dpdk.org
> > Subject: Re: [PATCH 19.11] net/iavf: fix Rx queue interrupt setting
> >
> > On Wed, Jul 20, 2022 at 7:28 AM Ke Zhang <ke1x.zhang at intel.com> wrote:
> > >
> > > [ upstream commit a08f9cb698c3d4687765860e328dca727f7a516b ]
> >
> > Thank you,
> > your patch was too late in regard to my original deadline and I was
> > then unavailable for a while.
> > In the meantime more patches came in and I do not want to waste any of
> > them just because they were late.
> >
> > Your patch is applied to the WIP branch now, but currently testing of
> > -rc1 is going on which I do not want to disrupt.
> >
>
> Hello,
>
> I believe this is causing the following build failure in 19.11.13-rc2:

I agree, I was trusting manual backports too much and releasing while
tests were still ongoing in the background.
Expect an -rc3 later today (this time with test builds completed
before tagging).

> """
> In file included from drivers/net/iavf/iavf_ethdev.c:13:
> drivers/net/iavf/iavf_ethdev.c: In function 'iavf_dev_rx_queue_intr_disable':
> drivers/net/iavf/iavf_ethdev.c:1212:9: error: 'IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK' undeclared (first use in this function); did you mean 'IAVFINT_DYN_CTLN1_WB_ON_ITR_MASK'?
>  1212 |         IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/librte_eal/common/include/arch/x86/rte_byteorder.h:74:30: note: in definition of macro 'rte_cpu_to_le_32'
>    74 | #define rte_cpu_to_le_32(x) (x)
>       |                              ^
> drivers/net/iavf/base/iavf_osdep.h:116:2: note: in expansion of macro 'IAVF_PCI_REG_WRITE'
>   116 |  IAVF_PCI_REG_WRITE(IAVF_PCI_REG_ADDR((hw), (reg)), (value))
>       |  ^~~~~~~~~~~~~~~~~~
> drivers/net/iavf/iavf_ethdev.c:1210:2: note: in expansion of macro 'IAVF_WRITE_REG'
>  1210 |  IAVF_WRITE_REG(hw,
>       |  ^~~~~~~~~~~~~~
> drivers/net/iavf/iavf_ethdev.c:1212:9: note: each undeclared identifier is reported only once for each function it appears in
>  1212 |         IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK);
>       |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> lib/librte_eal/common/include/arch/x86/rte_byteorder.h:74:30: note: in definition of macro 'rte_cpu_to_le_32'
>    74 | #define rte_cpu_to_le_32(x) (x)
>       |                              ^
> drivers/net/iavf/base/iavf_osdep.h:116:2: note: in expansion of macro 'IAVF_PCI_REG_WRITE'
>   116 |  IAVF_PCI_REG_WRITE(IAVF_PCI_REG_ADDR((hw), (reg)), (value))
>       |  ^~~~~~~~~~~~~~~~~~
> drivers/net/iavf/iavf_ethdev.c:1210:2: note: in expansion of macro 'IAVF_WRITE_REG'
>  1210 |  IAVF_WRITE_REG(hw,
>       |  ^~~~~~~~~~~~~~
> """
>
> I can reproduce on Ubuntu 20.04 with gcc 9.4.0.
>
> - Ali



-- 
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd