[EXT] Re: [PATCH v4 1/2] drivers: fix symbol exports when map is omitted

Akhil Goyal gakhil at marvell.com
Mon Dec 5 11:43:57 CET 2022


> On Fri, Dec 2, 2022 at 2:39 PM Aaron Conole <aconole at redhat.com> wrote:
> >
> > David Marchand <david.marchand at redhat.com> writes:
> >
> > > ld exports any global symbol by default if no version script is passed.
> > > As a consequence, the incriminated change let any public symbol leak
> > > out of the driver shared libraries.
> > >
> > > Hide again those symbols by providing a default map file which
> > > unexports any global symbol using a local: * catch-all statement.
> > >
> > > The checks are skipped for this default map file as it is intentionnally
> > > an empty map (see commit b67bdda86cd4 ("devtools: catch empty symbol
> > > maps")) and there is nothing else to check in this map.
> > >
> > > This change impacts the exported symbols, hence, bump the version in the
> > > ABI check to the v22.11.1 from the 22.11 LTS branch.
> > >
> > > Fixes: 7dde9c844a37 ("drivers: omit symbol map when unneeded")
> > > Cc: stable at dpdk.org
> > >
> > > Reported-by: Luca Boccassi <luca.boccassi at microsoft.com>
> > > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > > Tested-by: Ferruh Yigit <ferruh.yigit at amd.com>
> > > Reviewed-by: Bruce Richardson <bruce.richardson at intel.com>
> > Acked-by: Aaron Conole <aconole at redhat.com>
> 
> Series applied.
> 
> Please, maintainers and CI teams, when you enable ABI checks in the
> main branch, or in the 22.11 LTS branch, use the dpdk-stable 22.11.1
> tag as a reference.
> Thanks.

Should we also add a tag on main repo, as new development does not happen
on stable tree?

Regards,
Akhil


More information about the stable mailing list