[PATCH] vhost: decrease log level for unimplemented request
Kevin Traynor
ktraynor at redhat.com
Thu Dec 8 12:10:36 CET 2022
On 06/12/2022 15:02, Maxime Coquelin wrote:
> This patch changes VHOST_USER_SET_VRING_ERR "not
> implemented" log level from INFO to DEBUG.
>
> Indeed, it is not required to support this message type,
> and since version 7.1, QEMU sends this message for every
> queue. It could confuse the end-user, thinking there is an
> issue where there are not.
>
> Implementing it could be an option, but it does nothing
> special on QEMU side but displaying an error message.
>
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
> Cc: stable at dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
> ---
> lib/vhost/vhost_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 9902ae9944..371d6304d6 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
>
> if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
> close(ctx->fds[0]);
> - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
>
> return RTE_VHOST_MSG_RESULT_OK;
> }
Debug level seem fine for this and this is what is done in QEMU. Not an
issue atm from what I see, but should we do the same for
VHOST_USER_SET_LOG_FD ?
More information about the stable
mailing list