[PATCH 20.11 1/4] net/ena: remove useless address check
David Marchand
david.marchand at redhat.com
Thu Dec 8 15:49:07 CET 2022
From: Ferruh Yigit <ferruh.yigit at intel.com>
[ upstream commit 7a4edfd7bbcd0a3bcb726bc8a109419a600273be ]
Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’:
./drivers/net/ena/ena_rss.c:140:66:
error: the comparison will always evaluate as ‘false’ for the
pointer operand in ‘reta_conf + 136’ must not be NULL
[-Werror=address]
140 | (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL)))
| ^~
Fixing it by removing useless check.
Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Acked-by: Michal Krawczyk <mk at semihalf.com>
Signed-off-by: David Marchand <david.marchand at redhat.com>
---
Note on backport:
- moved change to ena_ethdev.c,
---
drivers/net/ena/ena_ethdev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 64e38e49fa..a4aac5a892 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -643,8 +643,7 @@ static int ena_rss_reta_query(struct rte_eth_dev *dev,
int reta_conf_idx;
int reta_idx;
- if (reta_size == 0 || reta_conf == NULL ||
- (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL)))
+ if (reta_size == 0 || reta_conf == NULL)
return -EINVAL;
rte_spinlock_lock(&adapter->admin_lock);
--
2.38.1
More information about the stable
mailing list