[PATCH 20.11 1/4] net/ena: remove useless address check

Luca Boccassi bluca at debian.org
Thu Dec 8 17:55:10 CET 2022


On Thu, 2022-12-08 at 15:49 +0100, David Marchand wrote:
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> 
> [ upstream commit 7a4edfd7bbcd0a3bcb726bc8a109419a600273be ]
> 
> Reported by "gcc (GCC) 12.0.0 20211003 (experimental)":
> 
> ./drivers/net/ena/ena_rss.c: In function ‘ena_rss_reta_query’:
> ./drivers/net/ena/ena_rss.c:140:66:
> 	error: the comparison will always evaluate as ‘false’ for the
> 	pointer operand in ‘reta_conf + 136’ must not be NULL
> 	[-Werror=address]
>   140 |  (reta_size > RTE_RETA_GROUP_SIZE && ((reta_conf + 1) == NULL)))
>       |                                                       ^~
> 
> Fixing it by removing useless check.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> Acked-by: Michal Krawczyk <mk at semihalf.com>
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
> Note on backport:
> - moved change to ena_ethdev.c,
> 
> ---
>  drivers/net/ena/ena_ethdev.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Thanks, all applied and pushed.

-- 
Kind regards,
Luca Boccassi


More information about the stable mailing list