19.11.14 patches review and test

[Christian Ehrhardt]

On Sun, Dec 11, 2022 at 3:40 PM Ali Alnubani <alialnu at nvidia.com> wrote:
>
> > -----Original Message-----
> > From: christian.ehrhardt at canonical.com
> > <christian.ehrhardt at canonical.com>
> > Sent: Monday, November 28, 2022 3:17 PM
> > To: stable at dpdk.org
> > Cc: dev at dpdk.org; Abhishek Marathe <Abhishek.Marathe at microsoft.com>;
> > Ali Alnubani <alialnu at nvidia.com>; benjamin.walker at intel.com; David
> > Christensen <drc at linux.vnet.ibm.com>; Hemant Agrawal
> > <hemant.agrawal at nxp.com>; Ian Stokes <ian.stokes at intel.com>; Jerin
> > Jacob <jerinj at marvell.com>; John McNamara <john.mcnamara at intel.com>;
> > Ju-Hyoung Lee <juhlee at microsoft.com>; Kevin Traynor
> > <ktraynor at redhat.com>; Luca Boccassi <bluca at debian.org>; Pei Zhang
> > <pezhang at redhat.com>; qian.q.xu at intel.com; Raslan Darawsheh
> > <rasland at nvidia.com>; NBU-Contact-Thomas Monjalon (EXTERNAL)
> > <thomas at monjalon.net>; yanghliu at redhat.com; yuan.peng at intel.com;
> > zhaoyan.chen at intel.com
> > Subject: 19.11.14 patches review and test
> >
> > Hi all,
> >
> > Here is a list of patches targeted for stable release 19.11.14.
> >
> > The planned date for the final release is Tue 12th December 2022.
> >
> > Please help with testing and validation of your use cases and report
> > any issues/results with reply-all to this mail. For the final release
> > the fixes and reported validations will be added to the release notes.
> >
> > A release candidate tarball can be found at:
> >
> >     https://dpdk.org/browse/dpdk-stable/tag/?id=v19.11.14-rc1
> >
> > These patches are located at branch 19.11 of dpdk-stable repo:
> >     https://dpdk.org/browse/dpdk-stable/
> >
> > Thanks.
> >
> > Christian Ehrhardt <christian.ehrhardt at canonical.com>
> >
> > ---
>
> Hello,
>
> We ran the following functional tests with Nvidia hardware on 19.11.14-rc1:
> - Basic functionality:
>   Send and receive multiple types of traffic.
> - testpmd xstats counter test.
> - testpmd timestamp test.
> - Changing/checking link status through testpmd.
> - RTE flow tests:
>   Items: eth / ipv4 / ipv6 / tcp / udp / icmp / gre / nvgre / geneve / vxlan / mplsoudp / mplsogre
>   Actions: drop / queue / rss / mark / flag / jump / count / raw_encap / raw_decap / vxlan_encap / vxlan_decap / NAT / dec_ttl
> - Some RSS tests.
> - VLAN filtering, stripping and insertion tests.
> - Checksum and TSO tests.
> - ptype tests.
> - link_status_interrupt example application tests.
> - l3fwd-power example application tests.
> - Multi-process example applications tests.
>
> Functional tests ran on:
> - NIC: ConnectX-4 Lx / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 14.32.1010
> - NIC: ConnectX-5 / OS: Ubuntu 20.04 LTS / Driver: MLNX_OFED_LINUX-5.8-1.0.1.1 / Firmware: 16.35.1012
>
> Additionally, we ran compilation tests with multiple configurations in the following OS/driver combinations, and they are passing:
> - Ubuntu 22.04.1 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> - Ubuntu 20.04.5 with MLNX_OFED_LINUX-5.8-1.1.2.1.
> - Ubuntu 20.04.5 with rdma-core master (76cfaa1).
> - Ubuntu 20.04.5 with rdma-core v28.0.
> - Ubuntu 18.04.6 with rdma-core v17.1.
> - Ubuntu 18.04.6 with rdma-core master (76cfaa1) (i386).
> - Ubuntu 16.04.7 with rdma-core v22.7.
> - CentOS 7 7.9.2009 with rdma-core master (76cfaa1).
> - CentOS 7 7.9.2009 with MLNX_OFED_LINUX-5.8-1.0.1.1.
> - CentOS 8 8.4.2105 with rdma-core master (76cfaa1).
> - OpenSUSE Leap 15.4 with rdma-core v38.1.
>
> We don't see any issues introduced by changes in this release.
>
> Builds on Fedora with gcc 12 and clang 15 are failing.
>
> Please note that not all the functional tests mentioned above fall under "Basic functionality with testpmd" like reported in the release notes for previous releases:
> https://git.dpdk.org/dpdk-stable/commit/?h=v19.11.13&id=104f5e8eb81e975809476fe894fc2781538ab752
>
> The following patch was missed in 19.11.13:
> https://inbox.dpdk.org/stable/DM4PR12MB516765207EE7A8999B284B5EDA1A9@DM4PR12MB5167.namprd12.prod.outlook.com/

Hi thanks for spotting it.
It has fallen through the cracks as the backport for 17f95513 was
already applied as edea6144.
But this was in fact a follow up fix to edea6144 itself, which I
failed to see at the time.

Ali, it still seems to apply cleanly and indeed is missing from the
former backport.
Do you think I can apply this without needing a full -rc2 of 19.11.14
(and thereby massively stalling the release due to a new test round)?

> Thanks,
> Ali




--
Christian Ehrhardt
Senior Staff Engineer, Ubuntu Server
Canonical Ltd