patch 'ethdev: fix Rx queue telemetry memory leak on failure' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Mon Feb 21 16:34:38 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/26/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/c935f2719dd828b22c0b2cd40eec2d65074cda28

Thanks.

Kevin

---
>From c935f2719dd828b22c0b2cd40eec2d65074cda28 Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Sat, 8 Jan 2022 15:51:57 +0800
Subject: [PATCH] ethdev: fix Rx queue telemetry memory leak on failure

[ upstream commit 52b49ea06ffb2cfbef8fe9578149f1e2dba99e89 ]

In eth_dev_handle_port_info() allocated memory for rxq_state,
we should free it when error happens, otherwise it will lead
to memory leak.

Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 lib/ethdev/rte_ethdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index a1d475a292..29e21ad580 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6321,6 +6321,8 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
 
 	txq_state = rte_tel_data_alloc();
-	if (!txq_state)
+	if (!txq_state) {
+		rte_tel_data_free(rxq_state);
 		return -ENOMEM;
+	}
 
 	rte_tel_data_start_dict(d);
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-02-21 15:22:46.555178033 +0000
+++ 0089-ethdev-fix-Rx-queue-telemetry-memory-leak-on-failure.patch	2022-02-21 15:22:44.184704335 +0000
@@ -1 +1 @@
-From 52b49ea06ffb2cfbef8fe9578149f1e2dba99e89 Mon Sep 17 00:00:00 2001
+From c935f2719dd828b22c0b2cd40eec2d65074cda28 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 52b49ea06ffb2cfbef8fe9578149f1e2dba99e89 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list