patch 'ethdev: remove unnecessary null check' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Mon Feb 21 16:35:51 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/26/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/6fdd1953b012a425dff6dffdc6e48db3b9bd4fac

Thanks.

Kevin

---
>From 6fdd1953b012a425dff6dffdc6e48db3b9bd4fac Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Wed, 9 Feb 2022 20:24:10 +0800
Subject: [PATCH] ethdev: remove unnecessary null check

[ upstream commit 8b8dd4451da45ce0419521d7e29fe246a5278251 ]

This NULL check is unnecessary, 'eth_dev' is never NULL.

Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Stephen Hemminger <stephen at networkplumber.org>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 lib/ethdev/rte_ethdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 917a320afa..e59958e6f5 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -6324,6 +6324,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
 
 	eth_dev = &rte_eth_devices[port_id];
-	if (!eth_dev)
-		return -EINVAL;
 
 	rxq_state = rte_tel_data_alloc();
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-02-21 15:22:48.057513605 +0000
+++ 0162-ethdev-remove-unnecessary-null-check.patch	2022-02-21 15:22:44.313704626 +0000
@@ -1 +1 @@
-From 8b8dd4451da45ce0419521d7e29fe246a5278251 Mon Sep 17 00:00:00 2001
+From 6fdd1953b012a425dff6dffdc6e48db3b9bd4fac Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8b8dd4451da45ce0419521d7e29fe246a5278251 ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -19 +20 @@
-index 3755a31795..155978c233 100644
+index 917a320afa..e59958e6f5 100644
@@ -22 +23 @@
-@@ -6466,6 +6466,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
+@@ -6324,6 +6324,4 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,



More information about the stable mailing list