patch 'net/txgbe: fix link up and down' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Mon Feb 21 16:36:12 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/26/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/42960ce4089d65aec41400db7c73a333a62e4c22

Thanks.

Kevin

---
>From 42960ce4089d65aec41400db7c73a333a62e4c22 Mon Sep 17 00:00:00 2001
From: Jiawen Wu <jiawenwu at trustnetic.com>
Date: Wed, 9 Feb 2022 18:42:12 +0800
Subject: [PATCH] net/txgbe: fix link up and down

[ upstream commit 2e1ecb460db92bc9dcd2350ed48dfe0b504f380f ]

Add hw->dev_start status in the flow of setting link up/down, to avoid
obtaining link status inconsistent with the settings.

Fixes: 12a653eb53e1 ("net/txgbe: fix link status when device stopped")

Signed-off-by: Jiawen Wu <jiawenwu at trustnetic.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index ac4d4e08f4..e2fcf87fe7 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -1938,4 +1938,5 @@ txgbe_dev_set_link_up(struct rte_eth_dev *dev)
 		/* Turn on the laser */
 		hw->mac.enable_tx_laser(hw);
+		hw->dev_start = true;
 		txgbe_dev_link_update(dev, 0);
 	}
@@ -1958,4 +1959,5 @@ txgbe_dev_set_link_down(struct rte_eth_dev *dev)
 		/* Turn off the laser */
 		hw->mac.disable_tx_laser(hw);
+		hw->dev_start = false;
 		txgbe_dev_link_update(dev, 0);
 	}
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-02-21 15:22:48.503443377 +0000
+++ 0183-net-txgbe-fix-link-up-and-down.patch	2022-02-21 15:22:44.362704737 +0000
@@ -1 +1 @@
-From 2e1ecb460db92bc9dcd2350ed48dfe0b504f380f Mon Sep 17 00:00:00 2001
+From 42960ce4089d65aec41400db7c73a333a62e4c22 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 2e1ecb460db92bc9dcd2350ed48dfe0b504f380f ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index b756ea5e6c..7b42285b9e 100644
+index ac4d4e08f4..e2fcf87fe7 100644
@@ -21 +22 @@
-@@ -1934,4 +1934,5 @@ txgbe_dev_set_link_up(struct rte_eth_dev *dev)
+@@ -1938,4 +1938,5 @@ txgbe_dev_set_link_up(struct rte_eth_dev *dev)
@@ -27 +28 @@
-@@ -1954,4 +1955,5 @@ txgbe_dev_set_link_down(struct rte_eth_dev *dev)
+@@ -1958,4 +1959,5 @@ txgbe_dev_set_link_down(struct rte_eth_dev *dev)



More information about the stable mailing list