patch 'crypto/ipsec_mb: fix premature dereference' has been queued to stable release 21.11.1

Kevin Traynor ktraynor at redhat.com
Mon Feb 21 16:36:16 CET 2022


Hi,

FYI, your patch has been queued to stable release 21.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/26/22. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable/commit/13aab9f4938569a1f9283d74e6bf7acdcad4290b

Thanks.

Kevin

---
>From 13aab9f4938569a1f9283d74e6bf7acdcad4290b Mon Sep 17 00:00:00 2001
From: Piotr Bronowski <piotrx.bronowski at intel.com>
Date: Sun, 16 Jan 2022 19:40:43 +0000
Subject: [PATCH] crypto/ipsec_mb: fix premature dereference

[ upstream commit 8c60a04985e7fbee288e780c8d50373d3e1ec678 ]

This patch removes coverity defect CID 374380:
Null pointer dereferences  (REVERSE_INULL)

Coverity issue: CID 374380
Fixes: 918fd2f1466b ("crypto/ipsec_mb: move aesni_mb PMD")

Signed-off-by: Piotr Bronowski <piotrx.bronowski at intel.com>
---
 drivers/crypto/ipsec_mb/ipsec_mb_private.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.h b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
index 866722d6f4..e53101acf1 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
@@ -192,6 +192,4 @@ ipsec_mb_parse_xform(const struct rte_crypto_sym_xform *xform,
 			const struct rte_crypto_sym_xform **aead_xform)
 {
-	const struct rte_crypto_sym_xform *next = xform->next;
-
 	if (xform == NULL) {
 		*mode = IPSEC_MB_OP_NOT_SUPPORTED;
@@ -199,4 +197,6 @@ ipsec_mb_parse_xform(const struct rte_crypto_sym_xform *xform,
 	}
 
+	const struct rte_crypto_sym_xform *next = xform->next;
+
 	if (xform->type == RTE_CRYPTO_SYM_XFORM_CIPHER) {
 		if (next == NULL) {
-- 
2.34.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2022-02-21 15:22:48.591718834 +0000
+++ 0187-crypto-ipsec_mb-fix-premature-dereference.patch	2022-02-21 15:22:44.374704764 +0000
@@ -1 +1 @@
-From 8c60a04985e7fbee288e780c8d50373d3e1ec678 Mon Sep 17 00:00:00 2001
+From 13aab9f4938569a1f9283d74e6bf7acdcad4290b Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8c60a04985e7fbee288e780c8d50373d3e1ec678 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org



More information about the stable mailing list