[PATCH 2/2] net/txgbe: fix debug log

[Jiawen Wu]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit at intel.com>
> Sent: Monday, February 21, 2022 9:10 PM
> To: Jiawen Wu <jiawenwu at trustnetic.com>; dev at dpdk.org
> Cc: stable at dpdk.org
> Subject: Re: [PATCH 2/2] net/txgbe: fix debug log
> 
> On 2/21/2022 9:21 AM, Jiawen Wu wrote:
> > diff --git a/drivers/net/txgbe/txgbe_logs.h
> > b/drivers/net/txgbe/txgbe_logs.h index 67e9bfb3af..38c5d05984 100644
> > --- a/drivers/net/txgbe/txgbe_logs.h
> > +++ b/drivers/net/txgbe/txgbe_logs.h
> > @@ -48,11 +48,8 @@ extern int txgbe_logtype_tx_free;
> >   #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0)
> >   #endif
> >
> > -#define TLOG_DEBUG(fmt, args...)  PMD_DRV_LOG(DEBUG, fmt, ##args)
> > -
> > -#define DEBUGOUT(fmt, args...)    TLOG_DEBUG(fmt, ##args)
> > -#define PMD_INIT_FUNC_TRACE()     TLOG_DEBUG(" >>")
> > -#define DEBUGFUNC(fmt)            TLOG_DEBUG(fmt)
> > +#define DEBUGOUT(fmt, args...)    PMD_DRV_LOG(fmt, ##args)
> > +#define PMD_INIT_FUNC_TRACE()     PMD_DRV_LOG(" >>")
> >
> 
> Hi Jiawen,
> 
> This won't work, macros are missing the log type.
> I guess intention is to change as done in ngbe patch [1].
> 
> I wonder if you send the patches even without compiling them?
> Expectation is authors test the patches before sending them out!
> 
> 
> [1]
>   PMD_DRV_LOG(DEBUG, fmt, ##args)

I'm so sorry.
I compiled and tested it, found and fixed the bug, but maybe I got the file location wrong when merging the codes.